Skip to content

Commit 8f2ca2c

Browse files
committed
Address PR comments
1 parent 93a57ae commit 8f2ca2c

3 files changed

Lines changed: 8 additions & 15 deletions

File tree

openapi/openapiv2.json

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10453,10 +10453,6 @@
1045310453
"$ref": "#/definitions/v1Priority",
1045410454
"description": "Priority metadata."
1045510455
},
10456-
"startDelay": {
10457-
"type": "string",
10458-
"description": "Time to wait before dispatching the first activity."
10459-
},
1046010456
"completionCallbacks": {
1046110457
"type": "array",
1046210458
"items": {
@@ -10471,7 +10467,7 @@
1047110467
"type": "object",
1047210468
"$ref": "#/definitions/apiCommonV1Link"
1047310469
},
10474-
"description": "Links to be associated with the activity."
10470+
"description": "Links to be associated with the activity. Callbacks may also have associated links;\nlinks already included with a callback should not be duplicated here."
1047510471
}
1047610472
}
1047710473
},

openapi/openapiv3.yaml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14302,10 +14302,6 @@ components:
1430214302
allOf:
1430314303
- $ref: '#/components/schemas/Priority'
1430414304
description: Priority metadata.
14305-
startDelay:
14306-
pattern: ^-?(?:0|[1-9][0-9]{0,11})(?:\.[0-9]{1,9})?s$
14307-
type: string
14308-
description: Time to wait before dispatching the first activity.
1430914305
completionCallbacks:
1431014306
type: array
1431114307
items:
@@ -14317,7 +14313,9 @@ components:
1431714313
type: array
1431814314
items:
1431914315
$ref: '#/components/schemas/Link'
14320-
description: Links to be associated with the activity.
14316+
description: |-
14317+
Links to be associated with the activity. Callbacks may also have associated links;
14318+
links already included with a callback should not be duplicated here.
1432114319
StartActivityExecutionResponse:
1432214320
type: object
1432314321
properties:

temporal/api/workflowservice/v1/request_response.proto

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2931,13 +2931,12 @@ message StartActivityExecutionRequest {
29312931
temporal.api.sdk.v1.UserMetadata user_metadata = 17;
29322932
// Priority metadata.
29332933
temporal.api.common.v1.Priority priority = 18;
2934-
// Time to wait before dispatching the first activity.
2935-
google.protobuf.Duration start_delay = 19;
29362934
// Callbacks to be called by the server when this activity reaches a terminal state.
29372935
// Callback addresses must be whitelisted in the server's dynamic configuration.
2938-
repeated temporal.api.common.v1.Callback completion_callbacks = 20;
2939-
// Links to be associated with the activity.
2940-
repeated temporal.api.common.v1.Link links = 21;
2936+
repeated temporal.api.common.v1.Callback completion_callbacks = 19;
2937+
// Links to be associated with the activity. Callbacks may also have associated links;
2938+
// links already included with a callback should not be duplicated here.
2939+
repeated temporal.api.common.v1.Link links = 20;
29412940
}
29422941

29432942
message StartActivityExecutionResponse {

0 commit comments

Comments
 (0)