Skip to content

Commit a9af758

Browse files
Jack-Worksptomato
authored andcommitted
Remove substr in Temporal tests
1 parent 1cd9571 commit a9af758

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

test/built-ins/Temporal/Instant/prototype/toString/timezone-string-datetime.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,20 +43,20 @@ assert.throws(RangeError, () => instance.toString({ timeZone }), "bare date-time
4343

4444
timeZone = "2021-08-19T17:30Z";
4545
const result1 = instance.toString({ timeZone });
46-
assert.sameValue(result1.substr(-6), "+00:00", "date-time + Z is UTC time zone");
46+
assert.sameValue(result1.slice(-6), "+00:00", "date-time + Z is UTC time zone");
4747

4848
timeZone = "2021-08-19T17:30-07:00";
4949
const result2 = instance.toString({ timeZone });
50-
assert.sameValue(result2.substr(-6), "-07:00", "date-time + offset is the offset time zone");
50+
assert.sameValue(result2.slice(-6), "-07:00", "date-time + offset is the offset time zone");
5151

5252
timeZone = "2021-08-19T17:30[UTC]";
5353
const result3 = instance.toString({ timeZone });
54-
assert.sameValue(result3.substr(-6), "+00:00", "date-time + IANA annotation is the offset time zone");
54+
assert.sameValue(result3.slice(-6), "+00:00", "date-time + IANA annotation is the offset time zone");
5555

5656
timeZone = "2021-08-19T17:30Z[UTC]";
5757
const result4 = instance.toString({ timeZone });
58-
assert.sameValue(result4.substr(-6), "+00:00", "date-time + Z + IANA annotation is the offset time zone");
58+
assert.sameValue(result4.slice(-6), "+00:00", "date-time + Z + IANA annotation is the offset time zone");
5959

6060
timeZone = "2021-08-19T17:30-07:00[UTC]";
6161
const result5 = instance.toString({ timeZone });
62-
assert.sameValue(result5.substr(-6), "+00:00", "date-time + offset + IANA annotation is the offset time zone");
62+
assert.sameValue(result5.slice(-6), "+00:00", "date-time + offset + IANA annotation is the offset time zone");

test/built-ins/Temporal/Instant/prototype/toString/timezone-string-leap-second.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const instance = new Temporal.Instant(0n);
1111
let timeZone = "2016-12-31T23:59:60+00:00[UTC]";
1212

1313
const result = instance.toString({ timeZone });
14-
assert.sameValue(result.substr(-6), "+00:00", "leap second is a valid ISO string for TimeZone");
14+
assert.sameValue(result.slice(-6), "+00:00", "leap second is a valid ISO string for TimeZone");
1515

1616
timeZone = "2021-08-19T17:30:45.123456789+23:59[+23:59:60]";
1717
assert.throws(RangeError, () => instance.toString({ timeZone }), "leap second in time zone name not valid");

test/built-ins/Temporal/Instant/prototype/toString/timezone-string-multiple-offsets.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ const instance = new Temporal.Instant(0n);
1111
const timeZone = "2021-08-19T17:30:45.123456789-12:12[+01:46]";
1212

1313
const result = instance.toString({ timeZone });
14-
assert.sameValue(result.substr(-6), "+01:46", "Time zone string determined from bracket name");
14+
assert.sameValue(result.slice(-6), "+01:46", "Time zone string determined from bracket name");

test/built-ins/Temporal/Instant/prototype/toString/timezone-string.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ features: [Temporal]
1010
const instance = new Temporal.Instant(0n);
1111

1212
const result1 = instance.toString({ timeZone: "UTC" });
13-
assert.sameValue(result1.substr(-6), "+00:00", "Time zone created from string 'UTC'");
13+
assert.sameValue(result1.slice(-6), "+00:00", "Time zone created from string 'UTC'");
1414

1515
const result2 = instance.toString({ timeZone: "-01:30" });
16-
assert.sameValue(result2.substr(-6), "-01:30", "Time zone created from string '-01:30'");
16+
assert.sameValue(result2.slice(-6), "-01:30", "Time zone created from string '-01:30'");

0 commit comments

Comments
 (0)