fix: replace hardcoded localhost URLs with PUBLIC_APP_URL env var, add CSS reset for breakout page

Author: stolinski

.beads/issues.jsonl

@@ -1,5 +1,6 @@
 {"id":"battle_mode-0dx","title":"Prevent submissions after time stopped","description":"","status":"open","priority":2,"issue_type":"bug","created_at":"2025-12-11T17:07:13.386735-07:00","updated_at":"2025-12-11T17:07:13.386735-07:00"}
 {"id":"battle_mode-5cc","title":"Fix BetterAuth JWKS decryption error","description":"Session error: Failed to decrypt private key. The BETTER_AUTH_SECRET may have changed or JWKS needs to be cleaned up.","status":"closed","priority":1,"issue_type":"bug","created_at":"2025-12-12T09:50:03.166659-07:00","updated_at":"2025-12-12T10:07:34.01619-07:00","closed_at":"2025-12-12T10:07:34.01619-07:00"}
+{"id":"battle_mode-5w2","title":"Replace hardcoded localhost URLs with env var domain","description":"Find all hardcoded localhost:5173 or localhost URLs in the codebase and replace with a PUBLIC_DOMAIN or similar env var so URLs work in both development and production environments.","status":"closed","priority":1,"issue_type":"task","created_at":"2025-12-12T11:03:07.82973-07:00","updated_at":"2025-12-12T11:09:11.277905-07:00","closed_at":"2025-12-12T11:09:11.277905-07:00"}
 {"id":"battle_mode-5zu","title":"Breakout reset styles","description":"","status":"open","priority":2,"issue_type":"task","created_at":"2025-12-11T17:07:15.090383-07:00","updated_at":"2025-12-11T17:07:15.090383-07:00"}
 {"id":"battle_mode-731","title":"Test Tailwind CDN","description":"","status":"open","priority":2,"issue_type":"task","created_at":"2025-12-11T17:26:55.268726-07:00","updated_at":"2025-12-11T17:26:55.268726-07:00"}
 {"id":"battle_mode-7fu","title":"Redesign homepage to be more of a real website instead of video game","description":"","status":"open","priority":2,"issue_type":"feature","created_at":"2025-12-11T17:21:20.431908-07:00","updated_at":"2025-12-11T17:21:20.431908-07:00"}
@@ -8,7 +9,7 @@
 {"id":"battle_mode-c49","title":"Prevent voting for anon users","description":"","status":"open","priority":2,"issue_type":"bug","created_at":"2025-12-11T17:07:13.622885-07:00","updated_at":"2025-12-11T17:07:13.622885-07:00"}
 {"id":"battle_mode-iwh","title":"Code based targets","description":"","status":"open","priority":2,"issue_type":"feature","created_at":"2025-12-11T17:07:14.597012-07:00","updated_at":"2025-12-11T17:07:14.597012-07:00"}
 {"id":"battle_mode-jbi","title":"AI avatars from GitHub","description":"","status":"open","priority":2,"issue_type":"feature","created_at":"2025-12-11T17:07:14.843567-07:00","updated_at":"2025-12-11T17:07:14.843567-07:00"}
-{"id":"battle_mode-jji","title":"Remove default padding and margin on battle view","description":"Remove default padding and margin in src/routes/(blank)/battle/[id]/code/","status":"open","priority":2,"issue_type":"bug","created_at":"2025-12-11T17:26:55.496068-07:00","updated_at":"2025-12-11T17:26:55.496068-07:00"}
+{"id":"battle_mode-jji","title":"Remove default padding and margin on battle view","description":"Remove default padding and margin in src/routes/(blank)/battle/[id]/code/","status":"closed","priority":2,"issue_type":"bug","created_at":"2025-12-11T17:26:55.496068-07:00","updated_at":"2025-12-12T11:01:56.083143-07:00","closed_at":"2025-12-12T11:01:56.083143-07:00"}
 {"id":"battle_mode-lpt","title":"Improve 2 person referee view with larger code","description":"","status":"open","priority":2,"issue_type":"feature","created_at":"2025-12-11T17:21:20.670372-07:00","updated_at":"2025-12-11T17:21:20.670372-07:00"}
 {"id":"battle_mode-otf","title":"Animations","description":"","status":"open","priority":2,"issue_type":"feature","created_at":"2025-12-11T17:06:36.455234-07:00","updated_at":"2025-12-11T17:06:36.455234-07:00"}
 {"id":"battle_mode-owa","title":"Add percentage completed via diff during battle","description":"Show real-time percentage completion by diffing user code against target as people work and save. Requires significant planning - need to determine diff algorithm, UI placement, performance considerations for real-time updates.","status":"open","priority":2,"issue_type":"epic","created_at":"2025-12-11T17:26:55.721812-07:00","updated_at":"2025-12-11T17:26:55.721812-07:00"}

src/lib/battle_mode/Battlers.svelte

@@ -13,6 +13,7 @@
 
 	import { copyToClipboard } from '$utils/clipboard';
 	import { z } from '$lib/zero.svelte';
+	import { PUBLIC_APP_URL } from '$env/static/public';
 
 	const {
 		battle,
@@ -110,7 +111,7 @@
 			class="battler empty-seat"
 			type="button"
 			onclick={() =>
-				handleCopy(`http://localhost:5173/battle/${battle.id}/lobby`)}
+				handleCopy(`${PUBLIC_APP_URL}/battle/${battle.id}/lobby`)}
 		>
 			{#if battle.status === 'PENDING'}
 				<div class="image-frame">

src/lib/battle_mode/ShareLinks.svelte

@@ -1,6 +1,7 @@
 <script lang="ts">
 	import Copybutton from '$lib/ui/Copybutton.svelte';
 	import type { Battle } from '$sync/schema';
+	import { PUBLIC_APP_URL } from '$env/static/public';
 	const {
 		battle,
 		code = true,
@@ -19,23 +20,23 @@
 		<Copybutton
 			label="Code"
 			disabled={battle.status !== 'PENDING'}
-			link={`http://localhost:5173/battle/${battle.id}/lobby`}
+			link={`${PUBLIC_APP_URL}/battle/${battle.id}/lobby`}
 		/>
 	{/if}
 
 	{#if watch}
 		<Copybutton
 			label="Watch"
 			disabled={battle.visibility !== 'PUBLIC' || battle.status === 'COMPLETED'}
-			link={`http://localhost:5173/battle/${battle.zero_room_id}/watch`}
+			link={`${PUBLIC_APP_URL}/battle/${battle.zero_room_id}/watch`}
 		/>
 	{/if}
 
 	{#if vote}
 		<Copybutton
 			label="Vote"
 			disabled={battle.visibility !== 'PUBLIC' || battle.status !== 'COMPLETED'}
-			link="http://localhost:5173/battle/{battle.zero_room_id}/watch/vote"
+			link={`${PUBLIC_APP_URL}/battle/${battle.zero_room_id}/watch/vote`}
 		/>
 	{/if}
 </div>

src/routes/(blank)/battle/[id]/code/breakout/+page.svelte

@@ -48,3 +48,10 @@
 </script>
 
 {@html code}
+
+<style>
+	:global(html, body) {
+		margin: 0;
+		padding: 0;
+	}
+</style>