chore: fix lint errors

Author: antsgar

packages/desktop/.eslintrc.js

@@ -9,6 +9,7 @@ module.exports = {
   rules: {
     'no-console': ['warn', { allow: ['warn', 'error'] }],
     '@typescript-eslint/no-var-requires': 'off',
+    '@typescript-eslint/no-require-imports': 'off',
   },
   globals: {
     zip: true,

packages/desktop/app/index.ts

@@ -27,7 +27,7 @@ if (userDataPathIndex > 0) {
     /** Make sure the path is actually a writeable folder */
     try {
       fs.closeSync(fs.openSync(path.join(userDataPath, 'sn-test-file'), 'w'))
-    } catch (e) {
+    } catch {
       console.error('Failed to write to provided user data path. Aborting')
       app.exit(1)
     }

packages/desktop/app/javascripts/Main/File/FilesManager.ts

@@ -43,7 +43,7 @@ export class FilesManager implements FilesManagerInterface {
     try {
       const data = await fs.promises.readFile(filepath, 'utf8')
       return JSON.parse(data)
-    } catch (error) {
+    } catch {
       return undefined
     }
   }
@@ -286,7 +286,7 @@ export class FilesManager implements FilesManagerInterface {
   async moveFile(source: PathLike, destination: PathLike): Promise<void> {
     try {
       await fs.promises.rename(source, destination)
-    } catch (_error) {
+    } catch {
       /** Fall back to copying and then deleting. */
       await fs.promises.copyFile(source, destination, fs.constants.COPYFILE_FICLONE_FORCE)
       await fs.promises.unlink(source)

packages/desktop/app/javascripts/Main/Keychain/Keychain.ts

@@ -27,7 +27,7 @@ async function ensureKeychainAccess(store: Store): Promise<BrowserWindow | undef
     try {
       await getKeychainValue()
       store.set(StoreKeys.UseNativeKeychain, true)
-    } catch (_) {
+    } catch {
       /** Can't access keychain. */
       if (keychainAccessIsUserConfigurable) {
         return askForKeychainAccess(store)

packages/desktop/app/javascripts/Main/Packages/Networking.ts

@@ -47,7 +47,7 @@ export async function getJSON<T>(url: string): Promise<T | undefined> {
         try {
           const parsed = JSON.parse(data)
           resolve(parsed)
-        } catch (error) {
+        } catch {
           resolve(undefined)
         }
       })

packages/desktop/app/javascripts/Main/Types/Paths.ts

@@ -39,14 +39,14 @@ export const Paths = {
   get homeDir(): string | undefined {
     try {
       return app.getPath('home')
-    } catch (error) {
+    } catch {
       return undefined
     }
   },
   get documentsDir(): string | undefined {
     try {
       return app.getPath('documents')
-    } catch (error) {
+    } catch {
       return undefined
     }
   },

packages/desktop/app/javascripts/Main/Window.ts

@@ -260,7 +260,7 @@ function fileUrlsAreEqual(a: string, b: string): boolean {
       bPath = lowercaseDriveLetter(bPath)
     }
     return aPath === bPath
-  } catch (error) {
+  } catch {
     return false
   }
 }
@@ -275,7 +275,7 @@ async function getPreviousWindowPosition() {
   let position: WindowPosition
   try {
     position = JSON.parse(await fs.promises.readFile(path.join(Paths.userDataDir, 'window-position.json'), 'utf8'))
-  } catch (e) {
+  } catch {
     return {
       bounds: {
         width: WINDOW_DEFAULT_WIDTH,