Skip to content

Expand singleflight boundary in ValidatingCache.Get to cover full hit+check and miss+load path #11197

Expand singleflight boundary in ValidatingCache.Get to cover full hit+check and miss+load path

Expand singleflight boundary in ValidatingCache.Get to cover full hit+check and miss+load path #11197

Triggered via pull request April 15, 2026 07:45
@yroblayrobla
synchronize #4798
issue-4729
Status Failure
Total duration 8m 1s
Artifacts

run-on-pr.yml

on: pull_request
Matrix: Tests / test-go-code
Linting  /  Lint Go Code
1m 15s
Linting / Lint Go Code
Codegen  /  Verify Code Generation
1m 5s
Codegen / Verify Code Generation
Docs  /  Verify Swagger Documentation
2m 26s
Docs / Verify Swagger Documentation
Spellcheck  /  Codespell
14s
Spellcheck / Codespell
License Headers  /  Check License Headers
23s
License Headers / Check License Headers
Security Scan  /  Grype Repository Scan
1m 0s
Security Scan / Grype Repository Scan
Security Scan  /  Go Vulnerability Check
1m 28s
Security Scan / Go Vulnerability Check
Helm Charts  /  Lint and Test Helm Charts
5m 6s
Helm Charts / Lint and Test Helm Charts
Build Skills  /  Build and Publish Skills
Build Skills / Build and Publish Skills
E2E Tests  /  Build ToolHive Binary
E2E Tests / Build ToolHive Binary
Operator CI  /  Build Operator
Operator CI / Build Operator
Operator CI  /  Generate CRD Docs
Operator CI / Generate CRD Docs
Operator CI  /  Generate CRDs
Operator CI / Generate CRDs
Operator CI  /  Operator Tests
Operator CI / Operator Tests
Operator CI  /  Operator Tests Integration
Operator CI / Operator Tests Integration
Matrix: Operator CI / E2E Tests Operator
Waiting for pending jobs
Matrix: E2E Tests / e2e-tests-core
Waiting for pending jobs
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 8 warnings
Linting / Lint Go Code
issues found
Linting / Lint Go Code: test/e2e/thv-operator/virtualmcp/virtualmcp_redis_session_test.go#L551
cannot use mcpGroupName (variable of type string) as *"github.com/stacklok/toolhive/cmd/thv-operator/api/v1alpha1".MCPGroupRef value in struct literal (typecheck)
Linting / Lint Go Code: test/e2e/thv-operator/virtualmcp/virtualmcp_redis_session_test.go#L360
cannot use mcpGroupName (variable of type string) as *"github.com/stacklok/toolhive/cmd/thv-operator/api/v1alpha1".MCPGroupRef value in struct literal
Linting / Lint Go Code: test/e2e/thv-operator/virtualmcp/virtualmcp_redis_session_test.go#L176
cannot use mcpGroupName (variable of type string) as *"github.com/stacklok/toolhive/cmd/thv-operator/api/v1alpha1".MCPGroupRef value in struct literal
Linting / Lint Go Code: test/e2e/thv-operator/virtualmcp/virtualmcp_redis_session_test.go#L65
cannot use mcpGroupName (variable of type string) as *"github.com/stacklok/toolhive/cmd/thv-operator/api/v1alpha1".MCPGroupRef value in struct literal
Security Scan / Grype Repository Scan
Failed minimum severity level. Found vulnerabilities with level 'medium' or higher
Codegen / Verify Code Generation
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: arduino/setup-task@v2. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Security Scan / Go Vulnerability Check
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/setup-go@v5.0.0. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Security Scan / Go Vulnerability Check
Failed to save: <h2>Our services aren't available right now</h2><p>We're working to restore all services as soon as possible. Please check back soon.</p>0cULfaQAAAADBf9rZZmNTQZWoWxJevntvTVNQMzExMDAwMTA1MDE3AEVkZ2U=
Security Scan / Go Vulnerability Check
Failed to restore: Cache service responded with 400
Helm Charts / Lint and Test Helm Charts
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: arduino/setup-task@v2, azure/setup-helm@1a275c3b69536ee54be43f2070a358922e12c8d4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Helm Charts / Lint and Test Helm Charts
No file matched to [/home/runner/work/toolhive/toolhive/**/*requirements*.txt,/home/runner/work/toolhive/toolhive/**/*requirements*.in,/home/runner/work/toolhive/toolhive/**/*constraints*.txt,/home/runner/work/toolhive/toolhive/**/*constraints*.in,/home/runner/work/toolhive/toolhive/**/pyproject.toml,/home/runner/work/toolhive/toolhive/**/uv.lock,/home/runner/work/toolhive/toolhive/**/*.py.lock]. The cache will never get invalidated. Make sure you have checked out the target repository and configured the cache-dependency-glob input correctly.
Tests / Test Go Code (ubuntu-8cores-32gb)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea, arduino/setup-task@v2. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/