Override hashCode on SProductField to match its equals#5281
Merged
Conversation
Member
Author
|
The failure is clear and consistent across all platforms. Here's the summary: The test Examples:
Root cause: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5220.
SProductField overrode equals() to compare name and schema, but lacked a matching hashCode() implementation, violating the Java contract that equal objects must have equal hash codes. This causes issues when SProductField instances are used in Sets or HashMaps.
Adds hashCode() override derived from the same fields used in equals comparison. Includes test verifying equal fields have matching hash codes and work correctly in collections.
Closes #5220.