From ccbfe4b7d2e23e36215db4a795d3c415e63388e6 Mon Sep 17 00:00:00 2001 From: Michael Wyatt Date: Mon, 14 Apr 2025 23:06:05 +0000 Subject: [PATCH 1/2] load config before launching deepspeed --- arctic_training/cli.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arctic_training/cli.py b/arctic_training/cli.py index f3e908e5..4853504c 100644 --- a/arctic_training/cli.py +++ b/arctic_training/cli.py @@ -22,6 +22,8 @@ def main(): + from arctic_training.config.trainer import get_config + parser = argparse.ArgumentParser( prog="arctic_training", formatter_class=argparse.RawDescriptionHelpFormatter, @@ -45,6 +47,9 @@ def main(): if not args.config.exists(): raise FileNotFoundError(f"Config file {args.config} not found.") + # Early catch any config errors + _ = get_config(args.config) + exe_path = shutil.which("arctic_training_run") env = os.environ.copy() From e98c53312f11963a93bd9c1003e5335650a4df8e Mon Sep 17 00:00:00 2001 From: Michael Wyatt Date: Tue, 15 Apr 2025 15:43:07 +0000 Subject: [PATCH 2/2] error on empty yaml value --- arctic_training/config/utils.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arctic_training/config/utils.py b/arctic_training/config/utils.py index fa1e29af..b55f89fc 100644 --- a/arctic_training/config/utils.py +++ b/arctic_training/config/utils.py @@ -40,3 +40,6 @@ def construct_mapping(self, node, deep=False): raise ValueError(f"Duplicate '{key}' key found in YAML on line {key_node.start_mark.line + 1}.") mapping.add(key) return super().construct_mapping(node, deep) + + def process_empty_scalar(self, node): + raise ValueError(f"Empty value found in YAML on line {node.line + 1}.")