feat: Serde benchmark testing#1078
Merged
Merged
Conversation
This was referenced May 23, 2026
Closed
jbelkins
commented
May 28, 2026
| { "self.region" }, | ||
| false, | ||
| false, | ||
| ), |
Contributor
Author
There was a problem hiding this comment.
region and signingRegion are added to non-AWS, smithy-swift-based clients because region & signing region are needed to configure sigv4 which is a Smithy-native auth scheme.
The properties are optional, so they may be omitted when configuring clients to use other auth schemes.
jbelkins
commented
May 28, 2026
| "Data(\"\"\"\n\$L\n\"\"\".utf8)", | ||
| test.body.get().replace("\\\"", "\\\\\""), | ||
| "Data(#\"\"\"\n\$L\n\"\"\"#.utf8)", | ||
| test.body.get(), |
Contributor
Author
There was a problem hiding this comment.
Here, we use Swift "raw strings" (i.e. #""" ... """#) to include string literal content exactly as written, and we remove the backslash escaping.
jbelkins
commented
May 28, 2026
| url, | ||
| ) | ||
| } | ||
| writer.write("telemetryProvider: telemetryProvider,") |
Contributor
Author
There was a problem hiding this comment.
The serde benchmark telemetry provider, which takes the performance measurements, is installed in serde benchmark tests and in protocol tests alike, though it has no effect when running protocol tests.
dayaffe
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds a specialization of the protocol test suite for testing serialization performance. "Serde benchmark" tests are defined as either HTTP request or HTTP response protocol tests, and are identified by the
serde-benchmarktag applied to the test.When a serde benchmark test is to be generated, the usual request / response protocol test body is modified to perform testing.
Specific changes:
Changes to protocol tests generally:
Datais to be constructed as an input or expectation of a test, Swift "raw strings" are used, and the string is no longer rendered with any escaping.Note: companion PR awslabs/aws-sdk-swift#2172 has no code changes and is opened only to run SDK testing with this change applied.
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.