Skip to content

Commit 6a2299a

Browse files
sjnimsclaude
andcommitted
chore: improve greet workflow and add YAML linting
- Add timeout-minutes and project-specific guidance to greet.yml - Add links to CONTRIBUTING.md and CODE_OF_CONDUCT.md - Add uvx yamllint command to docs and CONTRIBUTING.md - Add .yamllint.yml config for GitHub Actions workflows Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 7285dd9 commit 6a2299a

4 files changed

Lines changed: 45 additions & 7 deletions

File tree

.github/workflows/greet.yml

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,29 @@ jobs:
1717
# Skip bot accounts to avoid greeting automated tools
1818
if: github.actor != 'dependabot[bot]' && github.actor != 'claude[bot]'
1919
runs-on: ubuntu-latest
20+
timeout-minutes: 5
2021
permissions:
2122
issues: write
2223
pull-requests: write
2324
steps:
2425
- uses: actions/first-interaction@1c4688942c71f71d4f5502a26ea67c331730fa4d # v3.1.0
2526
with:
2627
issue_message: |
27-
👋 Thanks for opening your first issue! We appreciate your contribution to plugin-dev.
28+
Thanks for opening your first issue! 👋 We appreciate your contribution to plugin-dev.
2829
29-
Please make sure you've provided all the requested information in the issue template. Our maintainers will review this soon.
30+
**Resources:**
31+
- [Contributing Guide](CONTRIBUTING.md)
32+
- [Code of Conduct](CODE_OF_CONDUCT.md)
33+
34+
Please ensure you've provided all the requested information in the issue template.
35+
Our maintainers will review this soon!
3036
pr_message: |
31-
🎉 Thanks for opening your first pull request! We appreciate your contribution to plugin-dev.
37+
Thanks for opening your first pull request! 🎉 We appreciate your contribution to plugin-dev.
3238
33-
Please make sure:
34-
- [ ] You've filled out the PR template completely
35-
- [ ] All markdown is properly linted
36-
- [ ] You've tested the changes locally
39+
**Before merge, please ensure:**
40+
- [ ] You've read our [Contributing Guide](CONTRIBUTING.md)
41+
- [ ] All markdown is properly linted (`markdownlint '**/*.md' --ignore node_modules`)
42+
- [ ] Shell scripts pass validation (`shellcheck plugins/plugin-dev/skills/*/scripts/*.sh`)
43+
- [ ] You've tested the changes locally with `claude --plugin-dir plugins/plugin-dev`
3744
3845
A maintainer will review your PR soon. Feel free to ask questions if you need help!

.yamllint.yml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
---
2+
# yamllint configuration for GitHub Actions workflows
3+
4+
extends: default
5+
6+
rules:
7+
# GitHub Actions workflows don't require document start
8+
document-start: disable
9+
10+
# Disable line-length - GHA workflows have long inline scripts and URLs
11+
line-length: disable
12+
13+
# GHA uses truthy triggers like `on: push` which is fine
14+
truthy:
15+
allowed-values: ["true", "false", "on"]
16+
17+
# Single space before comments is acceptable
18+
comments:
19+
min-spaces-from-content: 1

CLAUDE.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@ markdownlint '**/*.md' --ignore node_modules
5555

5656
# Lint shell scripts
5757
shellcheck plugins/plugin-dev/skills/*/scripts/*.sh
58+
59+
# Lint YAML files
60+
uvx yamllint .github/workflows/
5861
```
5962

6063
## Key Conventions

CONTRIBUTING.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,15 @@ markdownlint '**/*.md' --ignore node_modules
143143
markdownlint '**/*.md' --ignore node_modules --fix
144144
```
145145

146+
### YAML Linting
147+
148+
GitHub Actions workflows must pass YAML linting:
149+
150+
```bash
151+
# Lint workflow files
152+
uvx yamllint .github/workflows/
153+
```
154+
146155
**Style Rules** (see `.markdownlint.json`):
147156

148157
- Use ATX-style headers (`#`, `##`, `###`)

0 commit comments

Comments
 (0)