55# Motivation
66
77<!--
8- Why is this change needed? Link issues with `Fixes #N` or `Refs #N`.
9- For larger changes, include a sentence on alternatives considered.
8+ Why is this change needed? What user-visible problem or internal
9+ shortcoming does it address? For larger changes, include a sentence on
10+ alternatives considered.
1011-->
1112
13+ # Changes
14+
15+ <!-- Bullet list of the concrete changes in this PR. -->
16+
17+ -
18+ -
19+ -
20+
1221# Test plan
1322
1423<!--
@@ -18,16 +27,40 @@ samkhya-bench.
1827-->
1928
2029- [ ] ` cargo fmt --all -- --check `
21- - [ ] ` cargo clippy --workspace --exclude samkhya-duckdb --exclude samkhya-py -- -D warnings `
22- - [ ] ` cargo test --workspace --exclude samkhya-duckdb --exclude samkhya-py `
30+ - [ ] ` cargo clippy --workspace --exclude samkhya-duckdb --exclude samkhya-py --exclude samkhya-postgres --all-features -- -D warnings `
31+ - [ ] ` cargo test --workspace --exclude samkhya-duckdb --exclude samkhya-py --no-fail-fast `
32+ - [ ] Added or updated tests for changed behavior
33+ - [ ] Public API changes are documented (rustdoc on the changed item)
34+ - [ ] ** Industry-standard metrics applied** if this PR touches measurement code: BCa bootstrap CIs (Efron-Tibshirani 1993), Wilcoxon paired signed-rank (1945), BH-FDR correction (1995), q-error per Moerkotte VLDB 2009 — see ` bench-results/METHODOLOGY.md `
2335
24- # Checklist
36+ # Naming-compliance checklist
2537
26- - [ ] Formatting passes (` cargo fmt --all -- --check ` )
27- - [ ] Clippy passes with ` -D warnings `
28- - [ ] Tests pass on ` ubuntu-latest ` -equivalent locally
29- - [ ] Public API changes are documented (rustdoc on the changed item)
30- - [ ] No new "learned" / "adaptive" / "AI" framing in user-facing text
31- (see ` samkhya.md ` §3 for the naming rules)
32- - [ ] No new external dependencies without a one-line justification in
33- the PR description
38+ - [ ] No "learned" / "adaptive" / "AI" framing in primary user-facing
39+ text (see [[ feedback-samkhya-naming]] rule: prefer "portable" /
40+ "feedback-driven" / "self-correcting" / "LLM-pluggable")
41+ - [ ] If this PR touches the ` Corrector ` trait surface, the
42+ pluggable-corrector-backend framing (GBT default · TabPFN-2.5 ·
43+ LLM TODO) is preserved (no single-backend framing in trait docs)
44+
45+ # Breaking changes
46+
47+ <!--
48+ samkhya is post-1.0. Public API and on-disk format changes are
49+ governed by `docs/SEMVER.md`. State the semver impact explicitly.
50+ -->
51+
52+ - Breaking change? <!-- yes / no -->
53+ - Semver impact: <!-- patch (1.x.y) / minor (1.x.0) / major (2.0.0) -->
54+ - If yes, link the deprecation note and migration guidance:
55+
56+ # Related issues
57+
58+ <!--
59+ Reference issues with `Fixes #N` or `Refs #N`. List any companion PRs
60+ in sibling crates.
61+ -->
62+
63+ ---
64+
65+ * By submitting this PR you agree to dual Apache-2.0 OR MIT licensing
66+ of your contribution.*
0 commit comments