Update linting and prettier (#2663)

* Update linting and prettier

* Tweak gitignore

Author: RobbieTheWagner

.eslintrc.js

@@ -1,20 +1,20 @@
 module.exports = {
   root: true,
   parserOptions: {
-    ecmaVersion: 2020,
+    ecmaVersion: 'latest',
     sourceType: 'module'
   },
-  extends: ['eslint:recommended', 'plugin:prettier/recommended'],
+  extends: ['eslint:recommended'],
   env: {
-    browser: true,
-    es6: true,
-    node: true
+    browser: true
   },
-  plugins: ['svelte3'],
+  plugins: [
+    'svelte3'
+  ],
   rules: {
     'max-lines': [
       'warn',
-      { max: 250, skipBlankLines: true, skipComments: true }
+      { max: 500, skipBlankLines: true, skipComments: true }
     ],
     'no-console': 'off',
     'prefer-const': 'off'
@@ -25,6 +25,20 @@ module.exports = {
       files: ['**/*.svelte'],
       processor: 'svelte3/svelte3'
     },
+    // Typescript files
+    {
+      parser: '@typescript-eslint/parser',
+      files: ['**/*.ts'],
+      plugins: ['@typescript-eslint'],
+      extends: ['plugin:@typescript-eslint/recommended'],
+      rules: {
+        '@typescript-eslint/no-unused-vars': [
+          'error',
+          { argsIgnorePattern: '^_' }
+        ],
+        'prefer-rest-params': 'off'
+      }
+    },
     // node files
     {
       files: [
@@ -38,7 +52,7 @@ module.exports = {
       ],
       parserOptions: {
         sourceType: 'module',
-        ecmaVersion: 2015
+        ecmaVersion: 2020
       },
       env: {
         node: true

.github/workflows/test.yml

@@ -3,6 +3,7 @@ name: Lint & Test
 on:
   push:
     branches:
+      - main
       - master
   pull_request: {}
 
@@ -22,7 +23,7 @@ jobs:
         run: pnpm install
 
       - name: Run linting
-        run: pnpm lint:js
+        run: pnpm lint
 
   typecheck:
     name: Type Check

.gitignore

@@ -2,16 +2,19 @@
 /.idea/
 /.vscode/
 
+.eslintcache
+.nyc_output/
+coverage/
+dist/
+node_modules/
+
 /.log/
-/.nyc_output/
-/coverage/
+
 /cypress/
 /docs/
-/dist/
 /site/
-/node_modules/
 /test/unit/dist
-/.DS_Store
+*.DS_Store
 /.sass-cache
 /npm-debug.log*
 /stats.html

.prettierrc.js

@@ -3,5 +3,7 @@
 module.exports = {
   arrowParens: 'always',
   trailingComma: 'none',
-  singleQuote: true
+  singleQuote: true,
+  plugins: ['prettier-plugin-svelte'],
+  overrides: [{ files: '*.svelte', options: { parser: 'svelte' } }]
 };

package.json

@@ -17,6 +17,8 @@
     "dev": "pnpm watch",
     "docs": "node_modules/.bin/jsdoc -c .jsdoc.js --verbose",
     "build:landing": "pnpm -F landing build",
+    "lint": "pnpm -F '*' lint",
+    "lint:fix": "pnpm -F '*' lint:fix",
     "lint:js": "pnpm -F '*' lint:js",
     "start": "pnpm watch",
     "test:ci": "pnpm build && pnpm test:unit:ci && pnpm test:cy:ci:chrome",
@@ -33,28 +35,28 @@
     "@babel/preset-env": "^7.24.3",
     "@release-it-plugins/lerna-changelog": "^6.1.0",
     "@release-it-plugins/workspaces": "^4.2.0",
+    "@typescript-eslint/eslint-plugin": "^7.4.0",
+    "@typescript-eslint/parser": "^7.4.0",
     "autoprefixer": "^10.4.19",
     "better-docs": "^2.7.3",
+    "concurrently": "^8.2.2",
     "cypress": "^13.7.1",
     "cypress-plugin-tab": "^1.0.5",
     "del": "^7.1.0",
     "eslint": "^8.56.0",
-    "eslint-config-prettier": "^9.1.0",
     "eslint-plugin-jest": "^27.6.3",
-    "eslint-plugin-prettier": "^5.1.3",
     "eslint-plugin-svelte3": "^4.0.0",
     "glob": "^10.3.10",
     "jsdoc": "^4.0.2",
     "jsdoc-template-ship-shape": "^0.1.1",
     "postcss": "^8.4.38",
     "postinstall-postinstall": "^2.1.0",
     "prettier": "^3.1.1",
+    "prettier-plugin-svelte": "^3.2.2",
     "release-it": "^17.1.1",
     "release-plan": "^0.9.0",
     "replace": "^1.2.2",
     "shepherd.js": "workspace:*",
-    "svelte": "^3.59.2",
-    "svelte-preprocess": "^5.1.3",
     "typescript": "^5.4.2"
   },
   "packageManager": "pnpm@8.15.4",