Skip to content

Commit adf6902

Browse files
committed
Address final cpflow review notes
1 parent 8424f27 commit adf6902

3 files changed

Lines changed: 8 additions & 7 deletions

File tree

.github/actions/cpflow-delete-control-plane-app/check-app-exists.sh

100644100755
File mode changed.

.github/cpflow-help.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
- Creates the review app if it does not exist
77
- Builds the PR commit image
88
- Deploys the image and comments with the review URL
9+
- The command must be the only text in the comment
910

1011
`/delete-review-app`
1112
- Deletes the review app when the PR is done

.github/workflows/cpflow-deploy-review-app.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -171,13 +171,6 @@ jobs:
171171
cpln_cli_version: ${{ vars.CPLN_CLI_VERSION }}
172172
cpflow_version: ${{ vars.CPFLOW_VERSION }}
173173

174-
- name: Detect release phase support
175-
if: steps.config.outputs.ready == 'true' && steps.source.outputs.allowed == 'true'
176-
id: release-phase
177-
uses: ./.github/actions/cpflow-detect-release-phase
178-
with:
179-
app_name: ${{ env.APP_NAME }}
180-
181174
- name: Check if review app exists
182175
if: steps.config.outputs.ready == 'true' && steps.source.outputs.allowed == 'true'
183176
id: check-app
@@ -213,6 +206,13 @@ jobs:
213206
set -euo pipefail
214207
cpflow setup-app -a "${APP_NAME}" --org "${CPLN_ORG}"
215208
209+
- name: Detect release phase support
210+
if: steps.config.outputs.ready == 'true' && steps.source.outputs.allowed == 'true' && (steps.check-app.outputs.exists == 'true' || steps.setup-review-app.outcome == 'success')
211+
id: release-phase
212+
uses: ./.github/actions/cpflow-detect-release-phase
213+
with:
214+
app_name: ${{ env.APP_NAME }}
215+
216216
- name: Create initial PR comment
217217
if: steps.config.outputs.ready == 'true' && steps.source.outputs.allowed == 'true' && (steps.check-app.outputs.exists == 'true' || steps.setup-review-app.outcome == 'success')
218218
id: create-comment

0 commit comments

Comments
 (0)