Skip to content

Commit 55b8fb2

Browse files
ihabadhamclaude
andcommitted
Align CI renderer log handling with Pro CI
Pro's own integration CI (react_on_rails_pro/.github/workflows/ pro-integration-tests.yml) runs the renderer with `pnpm run node-renderer &` — no log redirect — so renderer output interleaves with job stdout and is always visible without a special dump step. Our workflow inherited a redirect-to-/tmp/node-renderer.log pattern from PR #723 plus a follow-up if-failure cat step (commit 7dea094) that dumped the file after rspec. Both existed to work around the redirect; neither was in any reference. Drop the redirect and the associated cat calls (startup-failure cat, timeout cat, post-rspec failure dump). Renderer logs now appear inline with job output, same shape as Pro CI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent bc4e982 commit 55b8fb2

1 file changed

Lines changed: 3 additions & 11 deletions

File tree

.github/workflows/rspec_test.yml

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -87,13 +87,12 @@ jobs:
8787

8888
- name: Start Node renderer for SSR
8989
run: |
90-
node renderer/node-renderer.js > /tmp/node-renderer.log 2>&1 &
90+
node renderer/node-renderer.js &
9191
RENDERER_PID=$!
9292
echo "Waiting for Node renderer (PID $RENDERER_PID) on port 3800..."
9393
for i in $(seq 1 30); do
9494
if ! kill -0 $RENDERER_PID 2>/dev/null; then
95-
echo "Node renderer process exited unexpectedly. Log output:"
96-
cat /tmp/node-renderer.log
95+
echo "Node renderer process exited unexpectedly (see output above)."
9796
exit 1
9897
fi
9998
if nc -z localhost 3800 2>/dev/null; then
@@ -102,8 +101,7 @@ jobs:
102101
fi
103102
sleep 1
104103
done
105-
echo "Node renderer failed to start within 30 seconds. Log output:"
106-
cat /tmp/node-renderer.log
104+
echo "Node renderer failed to start within 30 seconds (see output above)."
107105
exit 1
108106
109107
- name: Run rspec with xvfb
@@ -112,9 +110,3 @@ jobs:
112110
run: bundle exec rake ci:rspec
113111
working-directory: ./ #optional
114112
options: ":99 -ac -screen scn 1600x1200x16"
115-
116-
- name: Dump Node renderer log on rspec failure
117-
if: failure()
118-
run: |
119-
echo "=== /tmp/node-renderer.log ==="
120-
cat /tmp/node-renderer.log || echo "(log not available)"

0 commit comments

Comments
 (0)