Skip to content

Commit 626956d

Browse files
MrSaneAppsclaude
andcommitted
refactor: Consolidate duplicate services and fix race conditions
Major cleanup to eliminate duplicate/triplicate code patterns: Services Consolidated: - Merged ThumbnailGeneratorService + SmartThumbnailService into unified ThumbnailService with strategy pattern (.aesthetic, .faceQuality, .fast) - Deleted unused RecordingCoordinator (dead code, functionality in AppState+Actions) - Removed dead microphoneEnabled property (isMicActive proxy already exists) State Management Fixes: - Added didSet to cameraEnabled for auto-sync with CameraState - Removed redundant cameraState.startCamera()/stopCamera() calls throughout - Single source of truth for camera state Critical Bug Fix: - Fixed race condition in screen recorder binding setup that caused "Source switch timed out" errors when user cancelled picker quickly - Made setupScreenRecorderBinding() synchronous instead of async Task Documentation Cleanup: - Removed 30+ obsolete analysis/planning documents - Consolidated into DEVELOPMENT.md 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent e0cd3b0 commit 626956d

131 files changed

Lines changed: 5233 additions & 16497 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.cursor/settings.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
// - GPT-5.2 Extra High Fast: Speed-optimized
1515
// - Auto Mode: Let Cursor pick per task
1616
// - MAX Mode: Enable for maximum capability
17-
//
17+
//
1818
// These settings control behavior, not model selection:
1919
"cursor.chat.maxTokens": 8000,
2020
"cursor.chat.enableCodeActions": true,

‎.gitignore‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,3 +67,6 @@ TestOutput.xcresult/
6767
*.o
6868
SaneVideo/Resources/Models/ggml-base.en.bin
6969
project.yml.ci_backup
70+
71+
# Ephemeral reports and analysis (AI-generated, test results, audits)
72+
reports/

‎.vscode/extensions.json‎

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,32 +3,32 @@
33
// Swift Language Support
44
"sswg.swift-lang",
55
"vscode.swift-format",
6-
6+
77
// SwiftLint (if available)
88
"shinnn.swiftlint",
9-
9+
1010
// Git & Version Control
1111
"eamodio.gitlens",
1212
"mhutchie.git-graph",
13-
13+
1414
// YAML Support (for project.yml, lefthook.yml)
1515
"redhat.vscode-yaml",
16-
16+
1717
// Ruby Support (for SaneMaster.rb, Fastlane)
1818
"rebornix.ruby",
1919
"wingrunr21.vscode-ruby",
20-
20+
2121
// Markdown Support (for documentation)
2222
"yzhang.markdown-all-in-one",
2323
"davidanson.vscode-markdownlint",
24-
24+
2525
// File Management
2626
"alefragnani.project-manager",
27-
27+
2828
// Code Quality
2929
"usernamehw.errorlens",
3030
"streetsidesoftware.code-spell-checker",
31-
31+
3232
// Productivity
3333
"formulahendry.auto-rename-tag",
3434
"christian-kohler.path-intellisense",
@@ -40,4 +40,3 @@
4040
"ms-python.python" // Not a Python project
4141
]
4242
}
43-

‎.vscode/settings.json‎

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
// ============================================
55
// These settings are optimized for Swift/macOS development
66
// Based on project requirements in DEVELOPMENT.md
7-
7+
88
// ============================================
99
// Swift Language Settings
1010
// ============================================
@@ -28,7 +28,7 @@
2828
// ============================================
2929
"files.maxMemoryForLargeFilesMB": 4096,
3030
"editor.largeFileOptimizations": true,
31-
31+
3232
// ============================================
3333
// SwiftLint Integration
3434
// ============================================
@@ -119,7 +119,7 @@
119119
"cursor.chat.enableFileCreation": true,
120120
"cursor.chat.maxTokens": 8000,
121121
"cursor.chat.model": "gpt-4",
122-
122+
123123
// ============================================
124124
// Git Integration
125125
// ============================================
@@ -158,7 +158,7 @@
158158
"editor.inlineSuggest.enabled": true,
159159
"editor.suggest.preview": true,
160160
"editor.suggest.showStatusBar": true,
161-
161+
162162
// ============================================
163163
// File Size Warnings (500 line limit)
164164
// ============================================
@@ -222,4 +222,3 @@
222222
"extensions.autoCheckUpdates": true,
223223
"extensions.autoUpdate": false
224224
}
225-

‎.vscode/tasks.json‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,4 +94,3 @@
9494
}
9595
]
9696
}
97-

‎ALTERNATIVE_TESTING.md‎

Lines changed: 0 additions & 204 deletions
This file was deleted.

0 commit comments

Comments
 (0)