Repository navigation
Commit 626956d
refactor: Consolidate duplicate services and fix race conditions
Major cleanup to eliminate duplicate/triplicate code patterns:
Services Consolidated:
- Merged ThumbnailGeneratorService + SmartThumbnailService into unified
ThumbnailService with strategy pattern (.aesthetic, .faceQuality, .fast)
- Deleted unused RecordingCoordinator (dead code, functionality in AppState+Actions)
- Removed dead microphoneEnabled property (isMicActive proxy already exists)
State Management Fixes:
- Added didSet to cameraEnabled for auto-sync with CameraState
- Removed redundant cameraState.startCamera()/stopCamera() calls throughout
- Single source of truth for camera state
Critical Bug Fix:
- Fixed race condition in screen recorder binding setup that caused
"Source switch timed out" errors when user cancelled picker quickly
- Made setupScreenRecorderBinding() synchronous instead of async Task
Documentation Cleanup:
- Removed 30+ obsolete analysis/planning documents
- Consolidated into DEVELOPMENT.md
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>1 parent e0cd3b0 commit 626956d
131 files changed
Lines changed: 5233 additions & 16497 deletions
File tree
- .cursor
- .vscode
- SaneVideo.xcodeproj
- SaneVideoTests
- Mocks
- SaneVideoUITests
- SaneVideo
- Core
- DI
- Models
- Testing
- Utilities
- Services
- Audio
- Camera
- Captions
- Coordinators
- Effects
- Export
- Recording
- Thumbnails
- Vision
- State
- Views
- Components
- Modifiers
- Settings
- Styles
- Windows
- Scripts
- build-logs
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
122 | | - | |
| 122 | + | |
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
| |||
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
161 | | - | |
| 161 | + | |
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
| |||
222 | 222 | | |
223 | 223 | | |
224 | 224 | | |
225 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
This file was deleted.
0 commit comments