Use take in iteration to avoid a clone

Author: akern40

src/dimension/dimension_trait.rs

@@ -197,9 +197,8 @@ pub trait Dimension:
     /// or None if there are no more.
     // FIXME: use &Self for index or even &mut?
     #[inline]
-    fn next_for(&self, index: Self) -> Option<Self>
+    fn next_for(&self, mut index: Self) -> Option<Self>
     {
-        let mut index = index;
         let mut done = false;
         for (&dim, ix) in zip(self.slice(), index.slice_mut()).rev() {
             *ix += 1;

src/iterators/mod.rs

@@ -18,8 +18,8 @@ mod windows;
 use alloc::vec::Vec;
 use std::iter::FromIterator;
 use std::marker::PhantomData;
-use std::ptr;
 use std::ptr::NonNull;
+use std::{mem, ptr};
 
 #[allow(unused_imports)] // Needed for Rust 1.64
 use rawpointer::PointerExt;
@@ -72,10 +72,7 @@ impl<A, D: Dimension> Iterator for Baseiter<A, D>
     #[inline]
     fn next(&mut self) -> Option<Self::Item>
     {
-        let index = match self.index {
-            None => return None,
-            Some(ref ix) => ix.clone(),
-        };
+        let index = self.index.take()?;
         let offset = D::stride_offset(&index, &self.strides);
         self.index = self.dim.next_for(index);
         unsafe { Some(self.ptr.offset(offset)) }