Add experimental unnamed_enum_variants feature gate#157274
Conversation
|
The parser was modified, potentially altering the grammar of (stable) Rust cc @fmease rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
|
r? @Kivooeo rustbot has assigned @Kivooeo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Reminder, once the PR becomes ready for a review, use |
|
@rustbot ready |
|
You can remove the r-a changes from this PR. The other changes are not dependent on them. And also, I don't want to merge the r-a PR until the rustc PR is merged. |
e39a747 to
e6b4102
Compare
|
@ChayimFriedman2 Ah, I'd mistakenly thought that the r-a parser was actually being utilized by rustc here based on the rustc dev guide. But indeed this change isn't dependent on r-a. I've removed the r-a bits from this PR entirely as requested. |
|
(wrong PR ^^) |
|
Quick question: is there a discussion on Zulip or anywhere else I can found input from t-lang about this experiment? |
|
@Kivooeo The tracking issue references the design meeting, where a lang experiment was approved. It's associated with an accepted 2026 project goal with its own tracking issue. There's some input on the RFC as well. |
|
Thanks! I will review today |
|
@bors r+ rollup |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 49b19d3 (parent) -> 0cf9681 (this PR) Test differencesShow 6 test diffsStage 1
Stage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0cf96812614b8250543d749629867b36f2757f4d --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (0cf9681): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.8%, secondary -2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 511.14s -> 512.762s (0.32%) |
This parses the basic syntax and defines a feature gate for the unnamed enum variants lang experiment, tracking issue #156628.
cc @joshtriplett, @scottmcm, @tmandry