Add extra unchecked_disjoint_bitor implementations.#147368
Open
bjoernager wants to merge 1 commit into
Open
Conversation
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
Contributor
Author
|
@rustbot label +T-libs-api -T-libs r? libs-api |
3 tasks
This comment has been minimized.
This comment has been minimized.
943d050 to
845a872
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
r? libs-api |
This comment has been minimized.
This comment has been minimized.
845a872 to
39c4367
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
39c4367 to
ac624b5
Compare
This comment has been minimized.
This comment has been minimized.
ac624b5 to
41533fe
Compare
This comment has been minimized.
This comment has been minimized.
41533fe to
4f310fa
Compare
This comment has been minimized.
This comment has been minimized.
…'i64', 'i128', and 'isize'; Update existing 'unchecked_disjoint_bitor' docs; Add 'must_use' to 'unchecked_disjoint_bitor';
4f310fa to
c24ec23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #135758.
This PR implements the
unchecked_disjoint_bitormethod for additional types:Our
disjoint_bitorintrinsic is already implemented for these types. This method specifically is also already present on unsigned, integral types.Additionally, this PR rewrites the existing docs for
unchecked_disjoint_bitorand adds themust_useattribute to the method.