Fix ICE in swap_binop()#16659
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @dswij rustbot has assigned @dswij. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Author
rustbot
added
the
beta-nominated
Make `swap_binop()` a method of `HirEqInterExpr`, and use the proper typeck to check the type of an expression.
samueltardieu
force-pushed
the
issues/16505
branch
from
db904a2 to
4ff2a24
Compare
Jarcho
approved these changes
Mar 4, 2026
rustbot
removed
the
S-waiting-on-review
flip1995
added
beta-accepted
Member
cuviper
pushed a commit
to cuviper/rust
that referenced
this pull request
Apr 9, 2026
Make `swap_binop()` a method of `HirEqInterExpr`, and use the proper typeck to check the type of an expression. changelog: none (fix of a regression, should be backported) Fixes rust-lang/rust-clippy#16505 <!-- TRIAGEBOT_START --> <!-- TRIAGEBOT_SUMMARY_START --> ### Summary Notes - [Beta-nomination](rust-lang/rust-clippy#16659 (comment)) by [samueltardieu](https://github.com/samueltardieu) *Managed by `@rustbot`—see [help](https://forge.rust-lang.org/triagebot/note.html) for details* <!-- TRIAGEBOT_SUMMARY_END --> <!-- TRIAGEBOT_END -->
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Apr 9, 2026
[beta] reverts and backports This reverts two `dbg!` changes to avoid regressions[^1][^2] in the upcoming 1.95 release: - std: avoid tearing `dbg!` prints #149869 - don't drop arguments' temporaries in `dbg!` #154074 - ... which was previously backported in #154725 This also reverts a stabilization over a late issue[^3] of semantics: - Stabilize `assert_matches` #137487 And a few other backport/reverts from `main`: - Revert performing basic const checks in typeck on stable #154930 / #155033 - Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph" #154712 - Clarify that core::range ranges do not have special syntax #155002 Clippy is backporting 2 ICE fixes and 1 perf regression (via #155051): - rust-lang/rust-clippy#16685 already backported in #154211 to stable. This makes sure that it doesn't regress again in beta/next stable - rust-lang/rust-clippy#16659 The ICE that is being fixed here was introduced in the 1.95 release cycle - rust-lang/rust-clippy#16652 Perf regression introduced in the 1.95 release cycle. [^1]: #153850 [^2]: #154988 [^3]: #154406
flip1995
removed
the
beta-accepted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
swap_binop()a method ofHirEqInterExpr, and use the proper typeck to check the type of an expression.changelog: none (fix of a regression, should be backported)
Fixes #16505
Summary Notes
Managed by
@rustbot—see help for details