Merge pull request #21725 from Veykril/push-skvpqzkooolm

Veykril · web-flow · commit d5d00a364a77 · 2026-02-28T17:09:40.000Z
fix: Fix wrong confiditon in `Visibility::min`
diff --git a/crates/hir-def/src/visibility.rs b/crates/hir-def/src/visibility.rs
@@ -234,7 +234,7 @@ impl Visibility {
                 if mod_.krate(db) == krate { Some(Visibility::Module(mod_, exp)) } else { None }
             }
             (Visibility::Module(mod_a, expl_a), Visibility::Module(mod_b, expl_b)) => {
-                if mod_a.krate(db) != mod_b.krate(db) {
+                if mod_a == mod_b {
                     // Most module visibilities are `pub(self)`, and assuming no errors
                     // this will be the common and thus fast path.
                     return Some(Visibility::Module(

Original file line number	Diff line number	Diff line change
`@@ -234,7 +234,7 @@ impl Visibility {`
`234`	`234`	`if mod_.krate(db) == krate { Some(Visibility::Module(mod_, exp)) } else { None }`
`235`	`235`	`}`
`236`	`236`	`(Visibility::Module(mod_a, expl_a), Visibility::Module(mod_b, expl_b)) => {`
`237`		`- if mod_a.krate(db) != mod_b.krate(db) {`
	`237`	`+ if mod_a == mod_b {`
`238`	`238`	// Most module visibilities are `pub(self)`, and assuming no errors
`239`	`239`	`// this will be the common and thus fast path.`
`240`	`240`	`return Some(Visibility::Module(`