-
Notifications
You must be signed in to change notification settings - Fork 41
document missing import restrictions #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tshepang
wants to merge
8
commits into
main
Choose a base branch
from
tshepang/document-use-restrictions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f96cea0
stray
tshepang 655bbe3
document missing import restrictions
tshepang f18f69d
be more formal
tshepang d02ce01
use normative language
tshepang f69dd3d
make "simple import" definition more clear, and fix one in main text
tshepang 91092bf
use more simple sentences
tshepang 2b56a0b
match existing style
tshepang 9c70941
this fills a prior gap
tshepang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence reads too broadly. Rust 2021 still allows imports through extern-prelude crate names, such as
use ::std::io;. The disallowed case is importing bare leading::itself, for exampleuse ::{self as root};.As written,
An external prelude cannot be imported.reads as though extern-prelude imports are disallowed wholesale.Could this be restated in terms of
::as the extern-prelude root instead? If so, the earlier global-path rules probably also need a follow-on update so Rust 2021 no longer appears to permit::self,::super,::crate, or::$crate.Support:
items.use.restrictions.extern-preludepaths.qualifiers.global-root.edition2018There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this wording:
A :t:
global pathshall not consist of a single :t:path segmentexpressed as :t:keywordcrate, :t:keyword$crate, :t:keywordself, or :t:keywordsuper.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PLeVasseur can you provide alternative wording... it's not clear to me what an extern prelude is (Reference does not make it clear either), and I also don't see how any rule appears to permit the import paths shown