Skip to content

Commit e6a4b3b

Browse files
committed
Fix warnings in Dockerfile
Fix warning related to obsolete/deprecated Dockerfile syntax. Signed-off-by: Andreia Ocanoaia <andreia.ocanoaia@gmail.com>
1 parent 039a324 commit e6a4b3b

1 file changed

Lines changed: 14 additions & 17 deletions

File tree

dockerfile/dropbox.Dockerfile

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,21 @@
33
FROM ubuntu:22.04
44

55
# Maintainer
6-
LABEL maintainer "Alexander Graf <alex@otherguy.io>"
6+
LABEL maintainer="Alexander Graf <alex@otherguy.io>"
77

88
# Build arguments
9-
ARG VCS_REF=master
9+
ARG VCS_REF=main
10+
ARG VERSION=""
1011
ARG BUILD_DATE=""
1112

1213
# http://label-schema.org/rc1/
13-
LABEL org.label-schema.schema-version "1.0"
14-
LABEL org.label-schema.name "Dropbox"
15-
LABEL org.label-schema.build-date "${BUILD_DATE}"
16-
LABEL org.label-schema.description "Standalone Dropbox client"
17-
LABEL org.label-schema.vcs-url "https://github.com/otherguy/docker-dropbox"
18-
LABEL org.label-schema.vcs-ref "${VCS_REF}"
14+
LABEL org.label-schema.schema-version="1.0"
15+
LABEL org.label-schema.name="Dropbox"
16+
LABEL org.label-schema.version="${VERSION}"
17+
LABEL org.label-schema.build-date="${BUILD_DATE}"
18+
LABEL org.label-schema.description="Standalone Dropbox client"
19+
LABEL org.label-schema.vcs-url="https://github.com/otherguy/docker-dropbox"
20+
LABEL org.label-schema.vcs-ref="${VCS_REF}"
1921

2022
# Required to prevent warnings
2123
ARG DEBIAN_FRONTEND=noninteractive
@@ -32,21 +34,16 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
3234
&& rm -rf /var/lib/apt/lists/*
3335

3436
# Create user and group
35-
RUN mkdir -p /opt/dropbox /opt/dropbox/.dropbox /opt/dropbox/Dropbox \
37+
RUN mkdir -p /opt/dropbox \
3638
&& useradd --home-dir /opt/dropbox --comment "Dropbox Daemon Account" --user-group --shell /usr/sbin/nologin dropbox \
3739
&& chown -R dropbox:dropbox /opt/dropbox
3840

3941
# Set language
40-
ENV LANG "en_US.UTF-8"
41-
ENV LANGUAGE "en_US.UTF-8"
42-
ENV LC_ALL "en_US.UTF-8"
43-
44-
# Generate locales
45-
RUN sed --in-place '/en_US.UTF-8/s/^# //' /etc/locale.gen \
46-
&& locale-gen
42+
ENV LANG="C.UTF-8"
43+
ENV LC_ALL="C.UTF-8"
4744

4845
# Change working directory
49-
WORKDIR /opt/dropbox/Dropbox
46+
WORKDIR /opt/dropbox
5047

5148
# Not really required for --net=host
5249
EXPOSE 17500

0 commit comments

Comments
 (0)