Some of the pub/sub examples within rust_pubsub and minimal_pub_sub seem redundant – in particular, rust_pubsub/simple_{publisher,subscriber} and minimal_pub_sub/minimal_{publisher,subscriber}. Some may find the multiplicity of pub/sub examples confusing (see discussion on Matrix).
I propose consolidating pub/sub examples:
- Remove
rust_pubsub since it overlaps with minimal_pub_sub.
- Ensure separate launch files for each example in
minimal_pub_sub. The goal is to clarify how the examples are intended to be run, supporting the reader in understanding which files go together.
- Optionally refactor code in the
minimal_pub_sub crate so it uses the pattern of always using a struct for a node.
rust_pubsub follows the pattern of a struct for each node while most of minimal_pub_sub simply uses variables within the main function. I'm presuming the node-struct pattern is more idiomatic since it's the one used in the documentation.
- Optionally rename the
minimal_pub_sub crate to pub_sub_demo. It follows the pattern of other crates in the repo.
I'm open to any suggestions and ideas. I'm new to the project so apologies in advance if I'm proposing anything foolish.
Some of the pub/sub examples within
rust_pubsubandminimal_pub_subseem redundant – in particular,rust_pubsub/simple_{publisher,subscriber}andminimal_pub_sub/minimal_{publisher,subscriber}. Some may find the multiplicity of pub/sub examples confusing (see discussion on Matrix).I propose consolidating pub/sub examples:
rust_pubsubsince it overlaps withminimal_pub_sub.minimal_pub_sub. The goal is to clarify how the examples are intended to be run, supporting the reader in understanding which files go together.minimal_pub_subcrate so it uses the pattern of always using a struct for a node.rust_pubsubfollows the pattern of a struct for each node while most ofminimal_pub_subsimply uses variables within themainfunction. I'm presuming the node-struct pattern is more idiomatic since it's the one used in the documentation.minimal_pub_subcrate topub_sub_demo. It follows the pattern of other crates in the repo.I'm open to any suggestions and ideas. I'm new to the project so apologies in advance if I'm proposing anything foolish.