Skip to content

Commit e42000a

Browse files
gustavoliraclaude
authored andcommitted
fix(e2e): remove page.reload() causing orchestrator RBAC test timeouts (#4494)
The page.reload() before goToPageUrl("/orchestrator") creates a race condition: the reload reloads the current page (which may be a workflow detail page or dashboard from a previous test), and the subsequent navigation can fail to complete, causing the "Workflows" heading to never appear and the test to timeout after 20s. Since goToPageUrl() calls page.goto() which navigates directly to the URL, the reload is unnecessary and harmful. Removing it from all 7 occurrences in the test file. Ref: https://issues.redhat.com/browse/RHDHBUGS-2671 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent d772ce1 commit e42000a

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

e2e-tests/playwright/e2e/plugins/orchestrator/orchestrator-rbac.spec.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ test.describe.serial("Test Orchestrator RBAC", () => {
115115
});
116116

117117
test("Test global orchestrator workflow access is allowed", async () => {
118-
await page.reload();
119118
await uiHelper.goToPageUrl("/orchestrator");
120119
await uiHelper.verifyHeading("Workflows");
121120

@@ -264,7 +263,6 @@ test.describe.serial("Test Orchestrator RBAC", () => {
264263
});
265264

266265
test("Test global orchestrator workflow read-only access - Run button disabled", async () => {
267-
await page.reload();
268266
await uiHelper.goToPageUrl("/orchestrator");
269267
await uiHelper.verifyHeading("Workflows");
270268

@@ -421,7 +419,6 @@ test.describe.serial("Test Orchestrator RBAC", () => {
421419
});
422420

423421
test("Test global orchestrator workflow denied access - no workflows visible", async () => {
424-
await page.reload();
425422
await uiHelper.goToPageUrl("/orchestrator");
426423
await uiHelper.verifyHeading("Workflows");
427424

@@ -559,7 +556,6 @@ test.describe.serial("Test Orchestrator RBAC", () => {
559556
});
560557

561558
test("Test individual workflow denied access - no workflows visible", async () => {
562-
await page.reload();
563559
await uiHelper.goToPageUrl("/orchestrator");
564560
await uiHelper.verifyHeading("Workflows");
565561

@@ -705,7 +701,6 @@ test.describe.serial("Test Orchestrator RBAC", () => {
705701
});
706702

707703
test("Test individual workflow read-write access - only Greeting workflow visible and runnable", async () => {
708-
await page.reload();
709704
await uiHelper.goToPageUrl("/orchestrator");
710705
await uiHelper.verifyHeading("Workflows");
711706

@@ -859,7 +854,6 @@ test.describe.serial("Test Orchestrator RBAC", () => {
859854
});
860855

861856
test("Test individual workflow read-only access - only Greeting workflow visible, Run button disabled", async () => {
862-
await page.reload();
863857
await uiHelper.goToPageUrl("/orchestrator");
864858
await uiHelper.verifyHeading("Workflows");
865859

@@ -1135,7 +1129,6 @@ test.describe.serial("Test Orchestrator RBAC", () => {
11351129
});
11361130

11371131
test("rhdh-qe user runs greeting workflow and captures instance ID", async () => {
1138-
await page.reload();
11391132
await uiHelper.goToPageUrl("/orchestrator");
11401133
await uiHelper.verifyHeading("Workflows");
11411134

0 commit comments

Comments
 (0)