Skip to content

Commit 0345e56

Browse files
zdrapelaclaude
andcommitted
docs: fix PR review comments in CI docs
- Simplify OSD-GCP nightly test description - Fix /ok-to-test org scope to include both openshift and redhat-developer Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 63d4db5 commit 0345e56

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

docs/e2e-tests/CI.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ For scenarios where tests are not automatically triggered, or when you need to m
1717

1818
1. **Commenting `/ok-to-test`:**
1919
- **Purpose:** This command is used to validate a PR for testing, especially important for external contributors or when tests are not automatically triggered.
20-
- **Who Can Use It:** Only members of the [openshift](https://github.com/openshift) GitHub organization can mark the PR with this comment.
20+
- **Who Can Use It:** Only members of the [openshift](https://github.com/openshift) or [redhat-developer](https://github.com/redhat-developer) GitHub organizations can mark the PR with this comment.
2121
- **Use Cases:**
2222
- **External Contributors:** For PRs from contributors outside the organization, a member needs to comment `/ok-to-test` to initiate tests.
2323
- **More Details:** For additional information about `/ok-to-test`, please refer to the [Kubernetes Community Pull Requests Guide](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#more-about-ok-to-test).
2424

2525
2. **Triggering Tests Post-Validation:**
26-
- After an `openshift` org member has validated the PR with `/ok-to-test`, anyone can trigger tests using the following commands:
26+
- After an `openshift` or `redhat-developer` org member has validated the PR with `/ok-to-test`, anyone can trigger tests using the following commands:
2727
- `/test ?` to get a list of all available jobs
2828
- `/test e2e-ocp-helm` for mandatory PR checks
2929
- **Note:** Avoid using `/test all` as it may trigger unnecessary jobs and consume CI resources. Instead, use `/test ?` to see available options and trigger only the specific tests you need.
@@ -51,7 +51,7 @@ If the initial automatically triggered tests fail, OpenShift-CI will add a comme
5151
- **Purpose:** Validate new PRs for code quality, functionality, and integration.
5252
- **Trigger:**
5353
- **Automatic:** When a PR includes code changes affecting tests (excluding doc-only changes), tests are automatically triggered.
54-
- **Manual:** When `/ok-to-test` is commented by an `openshift` org member for external contributors or when `/test`, `/test images`, or `/test e2e-ocp-helm` is commented after validation.
54+
- **Manual:** When `/ok-to-test` is commented by an `openshift` or `redhat-developer` org member for external contributors or when `/test`, `/test images`, or `/test e2e-ocp-helm` is commented after validation.
5555
- **Environment:** Runs on ephemeral OpenShift clusters managed by Hive. Kubernetes jobs use ephemeral EKS and AKS clusters on spot instances managed by [Mapt](https://github.com/redhat-developer/mapt). GKE uses a long-running cluster.
5656
- **Configurations:**
5757
- Tests are executed on both **RBAC** (Role-Based Access Control) and **non-RBAC** namespaces. Different sets of tests are executed for both the **non-RBAC RHDH instance** and the **RBAC RHDH instance**, each deployed in separate namespaces.
@@ -91,7 +91,7 @@ Nightly tests are run to ensure the stability and reliability of our codebase ov
9191
- **AKS Nightly Tests:** Nightly tests on Azure Kubernetes Service (AKS) using ephemeral clusters provisioned by [Mapt](https://github.com/redhat-developer/mapt). AKS is exclusively used for nightly runs (no PR checks).
9292
- **EKS Nightly Tests:** Nightly tests on AWS Elastic Kubernetes Service (EKS) using ephemeral clusters provisioned by Mapt.
9393
- **GKE Nightly Tests:** Nightly tests on Google Kubernetes Engine using a long-running shared cluster.
94-
- **OSD-GCP Nightly Tests:** Nightly tests on OpenShift Dedicated on GCP. Orchestrator is disabled and localization tests are skipped in this environment.
94+
- **OSD-GCP Nightly Tests:** Nightly tests on OpenShift Dedicated on GCP.
9595

9696
### Additional Nightly Jobs for Main Branch
9797

0 commit comments

Comments
 (0)