Optimize rdf:ID handling

Author: marcelotto

CHANGELOG.md

@@ -5,6 +5,19 @@ This project adheres to [Semantic Versioning](http://semver.org/) and
 [Keep a CHANGELOG](http://keepachangelog.com).
 
 
+## Unreleased
+
+Elixir versions < 1.14 and OTP version < 23 are no longer supported.
+
+### Added
+
+- optimization of `rdf:ID`/`rdf:nodeID` handling
+
+
+[Compare v1.2.0...HEAD](https://github.com/rdf-elixir/rdf-xml-ex/compare/v1.2.0...HEAD)
+
+
+
 ## v1.2.0 - 2024-08-07
 
 This version upgrades to RDF.ex v2.0.

lib/rdf/xml/decoder/element_node.ex

@@ -242,12 +242,16 @@ defmodule RDF.XML.Decoder.ElementNode do
     end
   end
 
-  defp nc_name(name) do
-    # TODO: NCNames are actually more restrictive; see https://www.w3.org/TR/REC-xml-names/#NT-NCName
-    if String.match?(name, ~r/^[a-zA-Z_]/) and not String.contains?(name, ~w[: /]) do
-      {:ok, name}
-    else
+  # TODO: NCNames are actually more restrictive; see https://www.w3.org/TR/REC-xml-names/#NT-NCName
+  defp nc_name(<<c, _::binary>> = name) when c in ?a..?z or c in ?A..?Z or c == ?_ do
+    if String.contains?(name, ~w[: /]) do
       {:error, %RDF.XML.ParseError{message: "invalid NCName #{name}"}}
+    else
+      {:ok, name}
     end
   end
+
+  defp nc_name(name) do
+    {:error, %RDF.XML.ParseError{message: "invalid NCName #{name}"}}
+  end
 end