diff --git a/internal/config/loader.go b/internal/config/loader.go index 030fd4b..118717b 100644 --- a/internal/config/loader.go +++ b/internal/config/loader.go @@ -99,7 +99,7 @@ func (l *Loader) loadFileWithIncludes(path string, visited map[string]bool) (*Co return nil, &ParseError{Path: path, Err: err} } - // Settings renamed in 2.3.0 are migrated here rather than at each use, so a + // Settings renamed in 2.2.0 are migrated here rather than at each use, so a // project written for an older release cannot silently lose them. config.DeprecationWarnings = config.MigrateDeprecatedKeys() diff --git a/internal/config/types.go b/internal/config/types.go index 3baf902..c9cbb31 100644 --- a/internal/config/types.go +++ b/internal/config/types.go @@ -184,7 +184,7 @@ type Domain struct { StoreCode string `yaml:"store_code,omitempty"` // Magento store/website code for multi-store setup StoreType string `yaml:"store_type,omitempty"` // "store" or "website" (default: "store") - // MageRunCode and MageRunType are the names these settings had before 2.3.0. + // MageRunCode and MageRunType are the names these settings had before 2.2.0. // They are still read, because the loader ignores unknown keys and a project // written for an older release would otherwise lose its store code without // any warning and serve the wrong store. @@ -494,7 +494,7 @@ func (s *Services) GetSearchService() *ServiceConfig { // validStoreTypes are the values Magento understands for MAGE_RUN_TYPE. var validStoreTypes = map[string]bool{"": true, "store": true, "website": true} -// MigrateDeprecatedKeys copies settings from the names they had before 2.3.0 and +// MigrateDeprecatedKeys copies settings from the names they had before 2.2.0 and // returns a warning for each one found, so a project keeps working while its // owner is told what to rename. func (c *Config) MigrateDeprecatedKeys() []string { diff --git a/vitepress/guide/faq.md b/vitepress/guide/faq.md index 6859ea7..8f4bbb5 100644 --- a/vitepress/guide/faq.md +++ b/vitepress/guide/faq.md @@ -296,7 +296,7 @@ Magento\Framework\Exception\NoSuchEntityException: The store that was requested Verify the store and try again. ``` -Up to 2.2 MageBox set `MAGE_RUN_CODE` to `default` for every domain, so Magento looked for a store with that exact code. From 2.3.0 it sends nothing unless the domain names a `store_code`, and Magento resolves the store itself. On an older release, or when you do want a specific store per domain, set the code: +Up to 2.1 MageBox set `MAGE_RUN_CODE` to `default` for every domain, so Magento looked for a store with that exact code. From 2.2.0 it sends nothing unless the domain names a `store_code`, and Magento resolves the store itself. On an older release, or when you do want a specific store per domain, set the code: ```bash magebox domain add mystore.test --store-code=my_store_code diff --git a/vitepress/reference/config-options.md b/vitepress/reference/config-options.md index 3731af4..81ebc0b 100644 --- a/vitepress/reference/config-options.md +++ b/vitepress/reference/config-options.md @@ -62,7 +62,7 @@ domains: Leave `store_code` out for a single-store project. MageBox then sends no `MAGE_RUN_CODE` at all and Magento resolves the store itself, which is what a project whose default store code is not `default` needs. -::: tip Renamed in 2.3.0 +::: tip Renamed in 2.2.0 `mage_run_code` and `mage_run_type` are the former names. They still work and print a deprecation warning on `magebox start`; rename them to `store_code` and `store_type`. :::