Skip to content

Commit 85e1130

Browse files
committed
Arm backend: Enable CPPCHECK linting
Signed-off-by: Per Held <per.held@arm.com> Change-Id: I1b28466d7f78d006a38b8d3c711670991cbc327a
1 parent 4d9b0e9 commit 85e1130

5 files changed

Lines changed: 47 additions & 4 deletions

File tree

.github/workflows/claude-code.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
uses: pytorch/test-infra/.github/workflows/_claude-code.yml@main
1212
with:
1313
setup_script: |
14-
pip install lintrunner==0.12.7 lintrunner-adapters==0.13.0
14+
pip install lintrunner==0.12.7 lintrunner-adapters==0.14.0
1515
pip install -r requirements-lintrunner.txt
1616
lintrunner init
1717
permissions:

.github/workflows/lint.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ jobs:
4646
- name: Install dependencies
4747
run: |
4848
pip install torch --index-url https://download.pytorch.org/whl/cpu
49-
pip install lintrunner==0.12.7 lintrunner-adapters==0.13.0
49+
pip install lintrunner==0.12.7 lintrunner-adapters==0.14.0
5050
pip install -r requirements-lintrunner.txt
5151
USE_CPP=0 pip install --no-build-isolation third-party/ao
5252
pip install pytest numpy parameterized huggingface_hub transformers timm expecttest types-requests
@@ -93,7 +93,7 @@ jobs:
9393

9494
- name: Install lintrunner and linters
9595
run: |
96-
pip install lintrunner==0.12.7 lintrunner-adapters==0.13.0
96+
pip install lintrunner==0.12.7 lintrunner-adapters==0.14.0
9797
pip install -r requirements-lintrunner.txt
9898
lintrunner init
9999

.lintrunner.toml

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,45 @@ init_command = [
106106
]
107107
is_formatter = true
108108

109+
[[linter]]
110+
code = 'CPPCHECK'
111+
include_patterns = [
112+
'backends/arm/**/*.cpp',
113+
'backends/arm/**/*.h',
114+
'backends/arm/**/*.hpp',
115+
'examples/arm/**/*.cpp',
116+
'examples/arm/**/*.h',
117+
'examples/arm/**/*.hpp',
118+
]
119+
exclude_patterns = [
120+
]
121+
command = [
122+
'python',
123+
'-m',
124+
'lintrunner_adapters',
125+
'run',
126+
'cppcheck_linter',
127+
'--enable=warning,style,unusedFunction',
128+
'--extra-arg=--check-level=exhaustive',
129+
'--extra-arg=--std=c++17',
130+
'--extra-arg=--language=c++',
131+
'--extra-arg=--inline-suppr',
132+
'--extra-arg=--inconclusive',
133+
'--extra-arg=--suppress=unusedStructMember',
134+
'--extra-arg=--suppress=toomanyconfigs',
135+
'--',
136+
'@{{PATHSFILE}}'
137+
]
138+
init_command = [
139+
'python',
140+
'-m',
141+
'lintrunner_adapters',
142+
'run',
143+
'pip_init',
144+
'--dry-run={{DRYRUN}}',
145+
'--requirement=requirements-lintrunner.txt',
146+
]
147+
109148
[[linter]]
110149
code = 'CMAKE'
111150
include_patterns = [

requirements-dev.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ wheel # For building the pip package archive.
99
zstd # Imported by resolve_buck.py.
1010
certifi # Imported by resolve_buck.py.
1111
lintrunner==0.12.7
12-
lintrunner-adapters==0.13.0
12+
lintrunner-adapters==0.14.0
1313

1414
pytest<9.0
1515
pytest-xdist

requirements-lintrunner.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,3 +22,7 @@ docformatter==1.7.5
2222

2323
# MyPy
2424
mypy==1.14.1
25+
26+
# Cppcheck and dependencies
27+
cppcheck==1.5.1
28+
defusedxml==0.7.1

0 commit comments

Comments
 (0)