Enable `checksum_flag` in zstd compression by default

[beavailable]

Feature or enhancement

Proposal:

For most common cases I think it's better to enable checksum_flag, because it costs almost nothing. By enabling it by default, the user doesn't need to explicitly provide an options parameter just for the checksum.
The zstd command line tool also enables it by default.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

[StanFromIreland]

CC @emmatyping

[emmatyping]

As far as I can tell, none of the third-party Zstandard modules include checksums by default. And I think that is reasonable. Not all users need checksumming, so I think it should be opt-in rather than opt-out.

Since libzstd also does not default to including checksums, I think we should leave this as-is.

[socketpair]

Well, it's Python. For example, be default no-one sets O_CLOEXEC. But Python does.

Why not to bring best practices? What are the downsides, especially if thoroughly documented?

[picnixz]

Well, it's Python. For example, be default no-one sets O_CLOEXEC. But Python does.

I don't think this is relevant to the discussion here.

Why not to bring best practices? What are the downsides, especially if thoroughly documented?

The CLI enables them by default, but not the backend. The frontend is more an application that makes some choices. If libzstd changes their defaults, we will do the same, but since we are mostly exposing the interface to the end-user, I agree that it's simply better to use the same defaults.

I'm closing this as not planned.