window.devicePixelRatio

[toastal]

Prerequisites

• Before opening a pull request, please check the HTML standard (https://dom.spec.whatwg.org/). If it doesn't appear in this spec, it may be present in the spec for one of the other purescript-web projects. Although MDN is a great resource, it is not a suitable reference for this project.

Description

According to the spec, this, devicePixelRatio, is under CSSOM. There exists a purescript-cssom library, however, other functions like scrollBy, scrollTo, etc. are also listed under CSSOM, but are in the Web.HTML library so I guess this should go here??

[thomashoneyman]

Technically, this function ought to go in purescript-web-cssom, but given its similarity to scrollX / scrollY and their existence here I think it's acceptable to merge here. We will at some point have to sweep back through the specs to migrate functions appropriately but there's not a concrete timeline for that.

[thomashoneyman]

(That said, given that we're making breaking changes as part of the updates for PureScript 0.14, we may want to go ahead and move other functions like scrollBy over to cssom now, rather than keep the status quo. For example: purescript-web/purescript-web-cssom#5. @garyb?)

[garyb]

I opened a comment on the cssom repo, it maybe shouldn't belong there either, it's defined in the cssom-view spec: https://www.w3.org/TR/cssom-view-1/#extensions-to-the-window-interface

[toastal]

Would there be a downside to have it duplicated in two places? People could possibly be looking for it in either?? I dunno..