PMM-14901: RTA details arrows respect filters#5397
Open
mattiasimonato wants to merge 16 commits into
Open
Conversation
mattiasimonato
requested review from
fabio-silva and
matejkubinec
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates RTA overview details-pane navigation so prev/next arrows traverse only the rows currently visible after table filtering (rather than the full API result set).
Changes:
OverviewTablenow exposes a filtered, pre-paginationnavigableQuerieslist derived from the MRT row model.RealtimeOverviewusesnavigableQueriesfor adjacent navigation and first/last button state.- Adds a unit test that mocks
OverviewTableto verify navigation ignores API-only (filtered-out) rows.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| ui/apps/pmm/src/pages/rta/overview/table/OverviewTable.tsx | Tracks table filter state and syncs a filtered/pre-pagination query list up to the parent for navigation. |
| ui/apps/pmm/src/pages/rta/overview/RealtimeOverview.tsx | Switches details-pane navigation to use the filtered query list rather than raw API results. |
| ui/apps/pmm/src/pages/rta/overview/RealtimeOverview.navigation.test.tsx | Adds tests ensuring next/prev navigation follows filtered rows, not the API’s full list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fabio-silva
requested changes
May 21, 2026
fabio-silva
requested changes
May 22, 2026
fabio-silva
approved these changes
May 22, 2026
fabio-silva
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-14901
Link to the Feature Build: SUBMODULES-4370
Fixes RTA overview details pane navigation so prev/next arrows move only through filtered table rows, not the full query list from the API.
OverviewTablesyncsnavigableQueriesfrom Material React Table (after column/global filters, before pagination).RealtimeOverviewuses that list for arrow navigation and first/last button state.