Add PostgreSQL 19 compatibility#654
Open
adeshthack wants to merge 1 commit into
Open
Conversation
PG19 introduces several API changes that break the build: - planner_hook gains an ExplainState *es parameter - QueryDesc->totaltime renamed to QueryDesc->query_instr with executor-managed instrumentation lifecycle (query_instr_options) - LWLockNewTrancheId() now requires a name argument - ShmemInitHash() drops the max_size parameter (5->4 args) - post_parse_analyze_hook JumbleState parameter is now const-qualified - escape_string_warning removed from core_yy_extra_type - storage/shmem.h, storage/proc.h, utils/tuplestore.h no longer transitively included All changes are guarded with #if PG_VERSION_NUM >= 190000 and have zero impact on PG 14-18. Tested against PG 19devel with all 22 regression tests and 34 TAP tests passing.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
PG19 introduces several API changes that break the build. This PR adds
C code changes (pg_stat_monitor.c, hash_query.c, pg_stat_monitor.h):
executor-managed instrumentation lifecycle (query_instr_options)
Test changes:
All changes use #if PG_VERSION_NUM >= 190000 / #else / #endif guards.
Tested against PG 19devel — all 22 regression tests and 34 TAP tests pass.
Links:
Related PostgreSQL 19 commits:
Upstream CI only tests PG 14-18: