pyo3: upgrade to v0.28.3 (#23230)

Upgrade to [PyO3
v0.28.3](https://github.com/PyO3/pyo3/releases/tag/v0.28.3). The main
change affecting Pants source is the need to now explicitly opt-in to
[the generation of `FromPyObject` on pyclass-types which are
`Clone`](https://pyo3.rs/v0.28.3/migration.html#deprecation-of-automatic-frompyobject-for-pyclass-types-which-implement-clone).

Author: tdyas

docs/notes/2.32.x.md

@@ -150,6 +150,8 @@ When generating lockfiles, the new `python.resolves_to_uploaded_prior_to` option
 
 ### Plugin API changes
 
+PyO3, the interface crate between Rust and Python, has been upgraded to v0.28.3.
+
 ## Full Changelog
 
 For the full changelog, see the individual GitHub Releases for this series: <https://github.com/pantsbuild/pants/releases>

src/rust/Cargo.lock

@@ -194,8 +194,8 @@ prodash = { git = "https://github.com/stuhood/prodash", rev = "stuhood/raw-messa
 prost = "0.13"
 prost-build = "0.13"
 prost-types = "0.13"
-pyo3 = { version = "0.27.2", features = ["parking_lot"] }
-pyo3-build-config = "0.27.2"
+pyo3 = { version = "0.28.3", features = ["parking_lot"] }
+pyo3-build-config = "0.28.3"
 rand = "0.10.0"
 regex = "1.12.3"
 reqwest = { version = "0.12", default-features = false }

src/rust/Cargo.toml

@@ -437,7 +437,7 @@ fn split_on_longest_dir_prefix<'a, 'b>(
     matched
 }
 
-#[pyclass(name = "Address")]
+#[pyclass(name = "Address", from_py_object)]
 #[derive(Clone, Hash, Eq, PartialEq, Ord, PartialOrd)]
 pub struct Address {
     // NB: Field ordering is deliberate, so that Ord will roughly match `self.spec`.

src/rust/engine/src/externs/address.rs

@@ -20,7 +20,7 @@ pub(crate) fn register(m: &Bound<'_, PyModule>) -> PyResult<()> {
     m.add_class::<PyInferenceMetadata>()
 }
 
-#[pyclass(name = "InferenceMetadata")]
+#[pyclass(name = "InferenceMetadata", from_py_object)]
 #[derive(Clone, Debug, PartialEq)]
 pub struct PyInferenceMetadata(pub dependency_inference_request::Metadata);
 
@@ -78,7 +78,7 @@ impl PyInferenceMetadata {
     }
 }
 
-#[pyclass(name = "NativeDependenciesRequest")]
+#[pyclass(name = "NativeDependenciesRequest", from_py_object)]
 #[derive(Clone, Debug, PartialEq)]
 pub struct PyNativeDependenciesRequest {
     pub directory_digest: DirectoryDigest,

src/rust/engine/src/externs/dep_inference.rs

@@ -56,7 +56,7 @@ pub fn possible_store_missing_digest(e: store::StoreError) -> PyErr {
     failure.into()
 }
 
-#[pyclass(name = "Digest")]
+#[pyclass(name = "Digest", from_py_object)]
 #[derive(Clone, Debug, PartialEq, Eq)]
 pub struct PyDigest(pub DirectoryDigest);
 
@@ -114,7 +114,7 @@ impl PyDigest {
     }
 }
 
-#[pyclass(name = "FileDigest")]
+#[pyclass(name = "FileDigest", from_py_object)]
 #[derive(Debug, Clone, PartialEq, Eq)]
 pub struct PyFileDigest(pub Digest);
 
@@ -501,7 +501,12 @@ impl PyFilespecMatcher {
 // -----------------------------------------------------------------------------
 
 /// The kind of path (e.g., file, directory, symlink) as identified in `PathMetadata`
-#[pyclass(name = "PathMetadataKind", rename_all = "UPPERCASE", eq)]
+#[pyclass(
+    name = "PathMetadataKind",
+    rename_all = "UPPERCASE",
+    eq,
+    from_py_object
+)]
 #[derive(Clone, Copy, Debug, Eq, PartialEq)]
 pub enum PyPathMetadataKind {
     File,
@@ -530,7 +535,7 @@ impl From<PyPathMetadataKind> for fs::PathMetadataKind {
 }
 
 /// Expanded version of `Stat` when access to additional filesystem attributes is necessary.
-#[pyclass(name = "PathMetadata")]
+#[pyclass(name = "PathMetadata", from_py_object)]
 #[derive(Clone, Debug, Eq, PartialEq)]
 pub struct PyPathMetadata(pub fs::PathMetadata);
 
@@ -652,7 +657,14 @@ impl PyPathMetadata {
 }
 
 /// The path's namespace (to separate buildroot and system paths)
-#[pyclass(name = "PathNamespace", rename_all = "UPPERCASE", frozen, eq, hash)]
+#[pyclass(
+    name = "PathNamespace",
+    rename_all = "UPPERCASE",
+    frozen,
+    eq,
+    hash,
+    from_py_object
+)]
 #[derive(Clone, Copy, Debug, Eq, PartialEq, Hash)]
 pub enum PyPathNamespace {
     Workspace,

src/rust/engine/src/externs/fs.rs

@@ -65,8 +65,8 @@ create_exception!(native_engine, EngineError, PyException);
 create_exception!(native_engine, IntrinsicError, EngineError);
 create_exception!(native_engine, IncorrectProductError, EngineError);
 
+#[pyclass(from_py_object)]
 #[derive(Clone)]
-#[pyclass]
 pub struct PyFailure(pub Failure);
 
 #[pymethods]

src/rust/engine/src/externs/mod.rs

@@ -17,7 +17,7 @@ pub(crate) fn register(m: &Bound<'_, PyModule>) -> PyResult<()> {
     Ok(())
 }
 
-#[pyclass(name = "ProcessExecutionEnvironment")]
+#[pyclass(name = "ProcessExecutionEnvironment", from_py_object)]
 #[derive(Clone, Debug, PartialEq, Eq, Hash)]
 pub struct PyProcessExecutionEnvironment {
     pub environment: ProcessExecutionEnvironment,

src/rust/engine/src/externs/process.rs

@@ -118,7 +118,7 @@ fn validate_choices(
     Ok(())
 }
 
-#[pyclass(name = "_NoValue")]
+#[pyclass(name = "_NoValue", from_py_object)]
 #[derive(Clone)]
 struct NoFieldValue;