[refactor] Remove unnecessary log messages from init script

Author: devkapilbansal

openwrt-openwisp-monitoring/files/monitoring.init

@@ -23,21 +23,6 @@ time_to_seconds() {
 	unset time
 }
 
-log() {
-	level="$1"
-	shift
-
-	case "$level" in
-		-i) level=daemon.info ;;
-		-w) level=daemon.warn ;;
-		-e) level=daemon.err ;;
-	esac
-
-	logger -s "$@" -p "$level" -t openwisp-monitoring
-
-	[ "$level" = daemon.err ] && exit 1
-}
-
 start_service() {
 	# for openwisp-config
 	config_load openwisp
@@ -54,10 +39,6 @@ start_service() {
 	[ -n "$key" ] && key="--key $key"
 	[ -n "$verify_ssl" ] && verify_ssl="--verify_ssl $verify_ssl"
 
-	[ -z "$base_url" ] && log -e "url is not set, please add it to /etc/config/openwisp"
-
-	[ -z "$uuid" ] || [ -z "$key" ] && log -e "uuid or key are not set, please add these to /etc/config/openwisp"
-
 	# for openwisp-monitoring
 	config_load openwisp-monitoring
 	config_get monitored_interfaces monitoring monitored_interfaces "*"
@@ -67,7 +48,7 @@ start_service() {
 	config_get max_retries monitoring max_retries "5"
 
 	interval="$(time_to_seconds "$interval")"
-	[ "$interval" -lt 1 ] && log -e "Interval is invalid. Use time value(eg: '10', '2m', '3h', '1d')"
+	[ -z "$interval" ] && { echo "Interval is invalid. Use time value(eg: '10', '2m', '3h', '1d')" 1>&2 && exit 1; }
 
 	interval="--interval $interval"
 	verbose="--verbose_mode ${verbose_mode:-0}"
@@ -88,11 +69,11 @@ start_service() {
 	procd_set_param respawn "${respawn_threshold:-3600}" "${respawn_timeout:-5}" "${respawn_retry:-5}"
 	procd_close_instance
 
-	log -i "$PROG_NAME started"
+	logger -s "$PROG_NAME started" -t openwisp-monitoring -p daemon.info
 }
 
 stop_service() {
-	log -i "$PROG_NAME stopping"
+	logger -s "$PROG_NAME stopping" -t openwisp-monitoring -p daemon.info
 }
 
 service_triggers() {