From e635772dc816195ab26e3ba91c92b052fa59cb1b Mon Sep 17 00:00:00 2001 From: Kris Raney Date: Fri, 17 Jul 2026 15:31:46 +0000 Subject: [PATCH] Add package & function comments This is cleanup that resolves some Google-internal linter warnings. There should be no change in behavior. --- cmd/internal/internal.go | 3 ++- cmd/release/release.go | 8 ++++++-- cmd/release/release_test.go | 6 +++--- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/cmd/internal/internal.go b/cmd/internal/internal.go index cc774bb2..fb701354 100644 --- a/cmd/internal/internal.go +++ b/cmd/internal/internal.go @@ -12,6 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. +// Package internal provides subcommands intended for internal KNE team use. package internal import ( @@ -25,6 +26,6 @@ func New() *cobra.Command { Use: "internal", Short: "Internal contains tools for internal KNE team use.", } - cmd.AddCommand(release.NewRelease()) + cmd.AddCommand(release.New()) return cmd } diff --git a/cmd/release/release.go b/cmd/release/release.go index f4e02cf9..24414bd4 100644 --- a/cmd/release/release.go +++ b/cmd/release/release.go @@ -12,6 +12,7 @@ // See the License for the specific language governing permissions and // limitations under the License. +// Package release provides subcommands for releasing KNE artifacts. package release import ( @@ -29,7 +30,8 @@ import ( "google.golang.org/api/option" ) -func NewRelease() *cobra.Command { +// New returns the release subcommand. +func New() *cobra.Command { cmd := &cobra.Command{ Use: "release", } @@ -132,7 +134,9 @@ func triggerBuild(ctx context.Context, trigger, tagOrSHA string, tag bool) (rErr if err != nil { return err } - fmt.Printf("Build ID: %s\nLogs: %s\n", md.GetBuild().GetId(), md.GetBuild().GetLogUrl()) + if md.Build != nil { + fmt.Printf("Build ID: %s\nLogs: %s\n", md.Build.GetId(), md.Build.GetLogUrl()) + } fmt.Println("Waiting for build to finish") b, err := op.Wait(ctx) if err != nil { diff --git a/cmd/release/release_test.go b/cmd/release/release_test.go index 58300d59..8321b5b7 100644 --- a/cmd/release/release_test.go +++ b/cmd/release/release_test.go @@ -18,10 +18,10 @@ import ( "testing" ) -func TestNewRelease(t *testing.T) { - cmd := NewRelease() +func TestNew(t *testing.T) { + cmd := New() if cmd == nil { - t.Fatalf("NewRelease() returned nil") + t.Fatalf("New() returned nil") } if cmd.Use != "release" { t.Errorf("cmd.Use = %q, want %q", cmd.Use, "release")