Default values only upon ::close

Author: franzpoeschel

include/openPMD/backend/Attributable.hpp

@@ -480,10 +480,6 @@ OPENPMD_protected
 
     void flushAttributes(internal::FlushParams const &);
 
-    void populateDefaults(
-        internal::ScientificDefaults *self,
-        internal::FlushParams const &params);
-
     enum ReadMode
     {
         /**

src/Iteration.cpp

@@ -135,10 +135,10 @@ Iteration &Iteration::close(bool _flush)
         break;
     }
 
-    // if (access::write(IOHandler()->m_frontendAccess))
-    // {
-    //     commitStructuralSetup();
-    // }
+    if (access::write(IOHandler()->m_frontendAccess))
+    {
+        populateMissingMetadata(true);
+    }
 
     if (_flush)
     {
@@ -442,7 +442,6 @@ void Iteration::flush(internal::FlushParams const &flushParams)
             particles.setDirty(false);
         }
 
-        populateDefaults(this, flushParams);
         flushAttributes(flushParams);
     }
     if (flushParams.flushLevel != FlushLevel::SkeletonOnly)

src/ParticleSpecies.cpp

@@ -182,7 +182,6 @@ void ParticleSpecies::flush(
     }
     else
     {
-        populateDefaults(this, flushParams);
         Container<Record>::flush(path, flushParams);
 
         for (auto &record : *this)

src/RecordComponent.cpp

@@ -521,7 +521,6 @@ void RecordComponent::flush(
             rc.m_chunks.pop();
         }
 
-        populateDefaults(this, flushParams);
         flushAttributes(flushParams);
     }
     if (flushParams.flushLevel != FlushLevel::SkeletonOnly)

src/backend/Attributable.cpp

@@ -383,16 +383,6 @@ void Attributable::flushAttributes(internal::FlushParams const &flushParams)
     }
 }
 
-void Attributable::populateDefaults(
-    internal::ScientificDefaults *self, internal::FlushParams const &params)
-{
-    if (params.flushLevel != FlushLevel::UserFlush)
-    {
-        return;
-    }
-    self->writeDefaults(IOHandler()->m_standard);
-}
-
 void Attributable::readAttributes(ReadMode mode)
 {
     auto &attri = get();

src/backend/BaseRecord.cpp

@@ -792,10 +792,6 @@ inline void BaseRecord<T_elem>::flush(
             "one or more regular components.");
     }
 
-    if (access::write(this->IOHandler()->m_backendAccess))
-    {
-        this->populateDefaults(this, flushParams);
-    }
     this->flush_impl(name, flushParams);
     if (flushParams.flushLevel != FlushLevel::SkeletonOnly)
     {

test/python/unittest/API/APITest.py

@@ -2376,6 +2376,7 @@ def get_component_only():
             mesh.axis_labels = ["x", "y"]
             component.reset_dataset(io.Dataset(np.dtype("float"), [10, 10]))
 
+            iteration.populate_missing_metadata(recursive=True)
             del iteration
             del mesh
             del series
@@ -2423,6 +2424,7 @@ def get_component_only():
             position.reset_dataset(
                 io.Dataset(np.dtype("float"), [num_particles]))
 
+            iteration.populate_missing_metadata(recursive=True)
             del iteration
             del particles
             del series
@@ -2474,6 +2476,7 @@ def get_component_only():
             num_particles_comp.store(0, np.uint64(10))
             num_particles_comp.store(1, np.uint64(20))
 
+            iteration.populate_missing_metadata(recursive=True)
             del iteration
             del particles
             del series