test: add missing descriptions to all tests

and make it an error to add such tests

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

Author: rgrinberg

test/blackbox-tests/dune

@@ -17,22 +17,14 @@
  (action
   (run %{bin:shellcheck} -s bash %{deps})))
 
-;; A list of tests that do not contain descriptions. This file should not not
-;; grow, only shrink. Once it is empty, it will become an error to introduce
-;; tests that do not have a description
-
+;; This rule is here to make sure that all of our tests have descriptions
 (rule
- (target lacking-description.gen)
+ (alias runtest)
+ (enabled_if %{bin-available:rg})
  (deps
   %{bin:rg}
   ;; CR-someday rgrinberg: we need a recursive glob for source_tree
   (source_tree test-cases))
  (action
   (system
-   "rg -L --files-without-match '^\\S' --glob \"*.t\" --glob \"!*coq*\" --glob \"!*rocq*\" --sort=path . > %{target}")))
-
-(rule
- (enabled_if %{bin-available:rg})
- (alias runtest)
- (action
-  (diff lacking-description lacking-description.gen)))
+   "rg -L --files-without-match '^\\S' --glob \"*.t\" --glob \"!*coq*\" --glob \"!*rocq*\"; [ $? -eq 1 ]")))

test/blackbox-tests/lacking-description

@@ -1,3 +1,5 @@
+Rejects switch-derived context names that come from absolute paths.
+
   $ cat > dune-project << EOF
   > (lang dune 3.0)
   > EOF

test/blackbox-tests/test-cases/absolute-switch-context-name-gh10721.t

@@ -1,3 +1,5 @@
+Tests that actions do not inherit stdin by default.
+
   $ echo "(lang dune 2.7)" > dune-project
   $ cat >dune <<EOF
   > (rule (with-stdout-to file.txt (run cat)))

test/blackbox-tests/test-cases/action-stdin-not-inherited-gh3672.t

@@ -1,3 +1,5 @@
+Checks `with-accepted-exit-codes` against matching and failing commands.
+
   $ cat > dune-project << EOF
   > (lang dune 2.0)
   > (using action-plugin 0.1)

test/blackbox-tests/test-cases/actions/with-exit-codes.t

@@ -1,3 +1,5 @@
+Allows nested action modifiers under `with-accepted-exit-codes` in Dune 2.2.
+
   $ cat > dune-project << EOF
   > (lang dune 2.2)
   > (using action-plugin 0.1)

test/blackbox-tests/test-cases/actions/with-nested-exit-codes.t

@@ -1,3 +1,5 @@
+Feeds an action's stdin from a file with `with-stdin-from`.
+
   $ cat > dune-project <<EOF
   > (lang dune 2.0)
   > EOF

test/blackbox-tests/test-cases/actions/with-stdin-from.t

@@ -1,3 +1,5 @@
+Rejects nested action modifiers under `with-accepted-exit-codes` before Dune 2.2.
+
   $ cat > dune-project << EOF
   > (lang dune 2.0)
   > (using action-plugin 0.1)

test/blackbox-tests/test-cases/actions/with-unsupported-nested-exit-codes.t

@@ -1,3 +1,5 @@
+Reports bad alias paths given as absolute paths.
+
   $ dune runtest
   File "dune", line 4, characters 9-17:
   4 |   (alias /foo/bar)))

test/blackbox-tests/test-cases/alias/bad-alias-error/absolute-path.t/run.t

@@ -1,3 +1,5 @@
+Reports bad alias paths outside the workspace.
+
   $ dune runtest
   File "dune", line 4, characters 9-42:
   4 |   (alias %{workspace_root}/../../../foobar)))