Skip to content

Commit 51cc6cb

Browse files
authored
test: remove unsupported Node version checks from fetch tests (#4977)
1 parent 4f4bf4f commit 51cc6cb

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

test/fetch/cookies.js

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@ const { Client, fetch, Headers } = require('../..')
88
const pem = require('@metcoder95/https-pem')
99
const { createSecureServer } = require('node:http2')
1010

11-
const isMacOSNode20CI = process.platform === 'darwin' &&
12-
Number(process.versions.node.split('.')[0]) === 20 &&
13-
process.env.CI
14-
1511
describe('cookies', () => {
1612
let server
1713

@@ -32,9 +28,7 @@ describe('cookies', () => {
3228
return once(server, 'close')
3329
})
3430

35-
test('Can receive set-cookie headers from a server using fetch - issue #1262', {
36-
skip: isMacOSNode20CI
37-
}, async (t) => {
31+
test('Can receive set-cookie headers from a server using fetch - issue #1262', async (t) => {
3832
const query = qsStringify({
3933
'set-cookie': 'name=value; Domain=example.com'
4034
})
@@ -65,9 +59,7 @@ describe('cookies', () => {
6559
}
6660
})
6761

68-
test('Cookie header is delimited with a semicolon rather than a comma - issue #1905', {
69-
skip: isMacOSNode20CI
70-
}, async (t) => {
62+
test('Cookie header is delimited with a semicolon rather than a comma - issue #1905', async (t) => {
7163
const response = await fetch(`http://localhost:${server.address().port}`, {
7264
headers: [
7365
['cookie', 'FOO=lorem-ipsum-dolor-sit-amet'],

test/fetch/issue-4105.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,9 @@ const { createServer } = require('node:http')
55
const { test } = require('node:test')
66
const { fetch } = require('../..')
77
const { PerformanceObserver } = require('node:perf_hooks')
8-
const isAtLeastv22 = process.versions.node.split('.').map(Number)[0] >= 22
98

109
// https://github.com/nodejs/undici/issues/4105
11-
test('markResourceTiming responseStatus is set', { skip: !isAtLeastv22 }, async (t) => {
10+
test('markResourceTiming responseStatus is set', async (t) => {
1211
t.plan(1)
1312

1413
const promise = Promise.withResolvers()

0 commit comments

Comments
 (0)