Make scroll on space bar customizable

[indexds]

Hello,

Great tool overall, just one nit that has been bugging me because of muscle memory: Currently when I select a resource there's a
self.move_selection(1) that "scrolls" automatically to the next resource. Coming from k9s this is a bit jarring. Would it be possible to make it configurable? I don't know if there's a goal for parity with k9s but if that is the case it would be better for it to be opt-in.

Happy to help if you want a PR :)

[indexds]

Also, related to this, right now there is no way to know you have selected something when you press space because the color does not change. You can only tell it has been selected once you move the selection to another resource. k9s fixes this by changing the background color of the selected resource. Could this be considered?

[nklmilojevic]

Thanks for this, and good catch on both!

You are right, k9s does not advance on space - it only toggles the mark. The comment in our code claiming k9s does it was wrong, so I am treating this as a parity bug and not adding a config option. If you want to mark a run of rows, ctrl+space marks the range.

Same for the second one - the cursor highlight was hiding the mark color, so a marked row under the cursor looked exactly like an unmarked one. Fixing it the k9s way, the cursor row gets the mark color as background when it is marked.

I will open a PR for both shortly :)

[Kumm-Kai]

You are right, k9s does not advance on space - it only toggles the mark. The comment in our code claiming k9s does it was wrong, so I am treating this as a parity bug and not adding a config option.

I still think a config setting would be nice for this. I liked sofkas previous behavior more 🙂