Skip to content

Commit 2407498

Browse files
icewind1991icewind1991
committed
chore: update workflows
Signed-off-by: Robin Appelman <robin@icewind.nl>
1 parent 3039c12 commit 2407498

8 files changed

Lines changed: 81 additions & 59 deletions

File tree

‎.github/workflows/appstore-build-publish.yml‎

Lines changed: 30 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
- uses: cachix/cachix-action@0fc020193b5a1fa3ac4575aa3a7d3aa6a35435ad # v16
2828
with:
2929
name: notify-push
30-
authToken: '${{ secrets.CACHIX_AUTH_TOKEN }}'
30+
authToken: "${{ secrets.CACHIX_AUTH_TOKEN }}"
3131

3232
- name: Check actor permission
3333
uses: skjnldsv/check-actor-permission@69e92a3c4711150929bca9fcf34448c5bf5526e7 # v3.0
@@ -41,7 +41,7 @@ jobs:
4141
echo "APP_VERSION=${GITHUB_REF##*/}" >> $GITHUB_ENV
4242
4343
- name: Checkout
44-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
44+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
4545
with:
4646
persist-credentials: false
4747
path: ${{ env.APP_NAME }}
@@ -72,15 +72,16 @@ jobs:
7272
continue-on-error: true
7373
with:
7474
path: ${{ env.APP_NAME }}
75-
fallbackNode: '^20'
76-
fallbackNpm: '^10'
75+
fallbackNode: "^24"
76+
fallbackNpm: "^11.3"
7777

7878
- name: Set up node ${{ steps.versions.outputs.nodeVersion }}
7979
# Skip if no package.json
8080
if: ${{ steps.versions.outputs.nodeVersion }}
81-
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
81+
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6.4.0
8282
with:
8383
node-version: ${{ steps.versions.outputs.nodeVersion }}
84+
package-manager-cache: false
8485

8586
- name: Set up npm ${{ steps.versions.outputs.npmVersion }}
8687
# Skip if no package.json
@@ -89,12 +90,12 @@ jobs:
8990

9091
- name: Get php version
9192
id: php-versions
92-
uses: icewind1991/nextcloud-version-matrix@58becf3b4bb6dc6cef677b15e2fd8e7d48c0908f # v1.3.1
93+
uses: icewind1991/nextcloud-version-matrix@8a7bac6300b2f0f3100088b297995a229558ddba # v1.3.2
9394
with:
9495
filename: ${{ env.APP_NAME }}/appinfo/info.xml
9596

9697
- name: Set up php ${{ steps.php-versions.outputs.php-min }}
97-
uses: shivammathur/setup-php@ccf2c627fe61b1b4d924adfcbd19d661a18133a0 # v2.35.2
98+
uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # 2.37.2
9899
with:
99100
php-version: ${{ steps.php-versions.outputs.php-min }}
100101
coverage: none
@@ -103,15 +104,17 @@ jobs:
103104

104105
- name: Check composer.json
105106
id: check_composer
106-
uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v3.0.0
107+
uses: andstor/file-existence-action@558493d6c74bf472d87c84eab196434afc2fa029 # v3.1.0
107108
with:
108109
files: "${{ env.APP_NAME }}/composer.json"
109110

110111
- name: Install composer dependencies
111112
if: steps.check_composer.outputs.files_exists == 'true'
112-
run: |
113-
cd ${{ env.APP_NAME }}
114-
composer install --no-dev
113+
uses: ramsey/composer-install@65e4f84970763564f46a70b8a54b90d033b3bdda # 4.0.0
114+
with:
115+
composer-options: "--no-dev"
116+
working-directory: ${{ env.APP_NAME }}
117+
ignore-cache: "yes"
115118

116119
- name: Build ${{ env.APP_NAME }}
117120
# Skip if no package.json
@@ -125,7 +128,7 @@ jobs:
125128
126129
- name: Check Krankerl config
127130
id: krankerl
128-
uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v3.0.0
131+
uses: andstor/file-existence-action@558493d6c74bf472d87c84eab196434afc2fa029 # v3.1.0
129132
with:
130133
files: ${{ env.APP_NAME }}/krankerl.toml
131134

@@ -147,17 +150,24 @@ jobs:
147150
cd ${{ env.APP_NAME }}
148151
make appstore
149152
150-
- name: Checkout server ${{ fromJSON(steps.appinfo.outputs.result).nextcloud.min-version }}
151-
continue-on-error: true
152-
id: server-checkout
153+
- name: Check server download link for ${{ fromJSON(steps.appinfo.outputs.result).nextcloud.min-version }}
153154
run: |
154155
NCVERSION='${{ fromJSON(steps.appinfo.outputs.result).nextcloud.min-version }}'
155-
wget --quiet https://download.nextcloud.com/server/releases/latest-$NCVERSION.zip
156-
unzip latest-$NCVERSION.zip
156+
DOWNLOAD_URL=$(curl -s "https://updates.nextcloud.com/updater_server/latest?channel=beta&version=$NCVERSION" | jq -r '.downloads.zip[0]')
157+
echo "DOWNLOAD_URL=$DOWNLOAD_URL" >> $GITHUB_ENV
158+
159+
- name: Download server ${{ fromJSON(steps.appinfo.outputs.result).nextcloud.min-version }}
160+
continue-on-error: true
161+
id: server-download
162+
if: ${{ env.DOWNLOAD_URL != 'null' }}
163+
run: |
164+
echo "Downloading release tarball from $DOWNLOAD_URL"
165+
wget $DOWNLOAD_URL -O nextcloud.zip
166+
unzip nextcloud.zip
157167
158168
- name: Checkout server master fallback
159-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
160-
if: ${{ steps.server-checkout.outcome != 'success' }}
169+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
170+
if: ${{ steps.server-download.outcome != 'success' }}
161171
with:
162172
persist-credentials: false
163173
submodules: true
@@ -180,7 +190,7 @@ jobs:
180190
tar -zcvf ${{ env.APP_NAME }}.tar.gz ${{ env.APP_NAME }}
181191
182192
- name: Attach tarball to github release
183-
uses: svenstaro/upload-release-action@81c65b7cd4de9b2570615ce3aad67a41de5b1a13 # v2.11.2
193+
uses: svenstaro/upload-release-action@29e53e917877a24fad85510ded594ab3c9ca12de # 2.11.5
184194
id: attach_to_release
185195
with:
186196
repo_token: ${{ secrets.GITHUB_TOKEN }}

‎.github/workflows/lint-info-xml.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,11 @@ jobs:
2424
name: info.xml lint
2525
steps:
2626
- name: Checkout
27-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
27+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
2828
with:
2929
persist-credentials: false
30+
sparse-checkout: |
31+
appinfo/
3032
3133
- name: Download schema
3234
run: wget https://raw.githubusercontent.com/nextcloud/appstore/master/nextcloudappstore/api/v1/release/info.xsd

‎.github/workflows/lint-php-cs.yml‎

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,16 @@ jobs:
2525

2626
steps:
2727
- name: Checkout
28-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
28+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
2929
with:
3030
persist-credentials: false
3131

3232
- name: Get php version
3333
id: versions
34-
uses: icewind1991/nextcloud-version-matrix@58becf3b4bb6dc6cef677b15e2fd8e7d48c0908f # v1.3.1
34+
uses: icewind1991/nextcloud-version-matrix@8a7bac6300b2f0f3100088b297995a229558ddba # v1.3.2
3535

3636
- name: Set up php${{ steps.versions.outputs.php-min }}
37-
uses: shivammathur/setup-php@ccf2c627fe61b1b4d924adfcbd19d661a18133a0 # v2.35.2
37+
uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # 2.37.2
3838
with:
3939
php-version: ${{ steps.versions.outputs.php-min }}
4040
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
@@ -43,10 +43,12 @@ jobs:
4343
env:
4444
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
4545

46-
- name: Install dependencies
46+
- name: Remove nextcloud/ocp
4747
run: |
4848
composer remove nextcloud/ocp --dev --no-scripts
49-
composer i
49+
50+
- name: Install composer dependencies
51+
uses: ramsey/composer-install@65e4f84970763564f46a70b8a54b90d033b3bdda # 4.0.0
5052

5153
- name: Lint
5254
run: composer run cs:check || ( echo 'Please run `composer run cs:fix` to format your code' && exit 1 )

‎.github/workflows/lint-php.yml‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,34 +21,35 @@ jobs:
2121
matrix:
2222
runs-on: ubuntu-latest-low
2323
outputs:
24-
php-versions: ${{ steps.versions.outputs.php-versions }}
24+
php-min: ${{ steps.versions.outputs.php-min }}
25+
php-max: ${{ steps.versions.outputs.php-max }}
2526
steps:
2627
- name: Checkout app
27-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
28+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
2829
with:
2930
persist-credentials: false
3031

3132
- name: Get version matrix
3233
id: versions
33-
uses: icewind1991/nextcloud-version-matrix@58becf3b4bb6dc6cef677b15e2fd8e7d48c0908f # v1.0.0
34+
uses: icewind1991/nextcloud-version-matrix@8a7bac6300b2f0f3100088b297995a229558ddba # v1.3.2
3435

3536
php-lint:
36-
runs-on: ubuntu-latest
37+
runs-on: ubuntu-latest-low
3738
needs: matrix
3839
strategy:
3940
matrix:
40-
php-versions: ${{fromJson(needs.matrix.outputs.php-versions)}}
41+
php-versions: ['${{ needs.matrix.outputs.php-min }}', '${{ needs.matrix.outputs.php-max }}']
4142

4243
name: php-lint
4344

4445
steps:
4546
- name: Checkout
46-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
47+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
4748
with:
4849
persist-credentials: false
4950

5051
- name: Set up php ${{ matrix.php-versions }}
51-
uses: shivammathur/setup-php@ccf2c627fe61b1b4d924adfcbd19d661a18133a0 # v2.35.2
52+
uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # 2.37.2
5253
with:
5354
php-version: ${{ matrix.php-versions }}
5455
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite

‎.github/workflows/phpunit-sqlite.yml‎

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ jobs:
2525
server-max: ${{ steps.versions.outputs.branches-max-list }}
2626
steps:
2727
- name: Checkout app
28-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
28+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
2929
with:
3030
persist-credentials: false
3131

3232
- name: Get version matrix
3333
id: versions
34-
uses: icewind1991/nextcloud-version-matrix@58becf3b4bb6dc6cef677b15e2fd8e7d48c0908f # v1.3.1
34+
uses: icewind1991/nextcloud-version-matrix@8a7bac6300b2f0f3100088b297995a229558ddba # v1.3.2
3535

3636
changes:
3737
runs-on: ubuntu-latest-low
@@ -43,7 +43,7 @@ jobs:
4343
src: ${{ steps.changes.outputs.src}}
4444

4545
steps:
46-
- uses: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36 # v3.0.2
46+
- uses: dorny/paths-filter@fbd0ab8f3e69293af611ebaee6363fc25e6d187d # v4.0.1
4747
id: changes
4848
continue-on-error: true
4949
with:
@@ -78,6 +78,7 @@ jobs:
7878
- 6379:6379
7979

8080
strategy:
81+
fail-fast: false
8182
matrix:
8283
php-versions: ${{ fromJson(needs.matrix.outputs.php-version) }}
8384
server-versions: ${{ fromJson(needs.matrix.outputs.server-max) }}
@@ -92,25 +93,25 @@ jobs:
9293
echo "APP_NAME=${GITHUB_REPOSITORY##*/}" >> $GITHUB_ENV
9394
9495
- name: Checkout server
95-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
96+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
9697
with:
9798
persist-credentials: false
9899
submodules: true
99100
repository: nextcloud/server
100101
ref: ${{ matrix.server-versions }}
101102

102103
- name: Checkout app
103-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
104+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
104105
with:
105106
persist-credentials: false
106107
path: apps/${{ env.APP_NAME }}
107108

108109
- name: Set up php ${{ matrix.php-versions }}
109-
uses: shivammathur/setup-php@ccf2c627fe61b1b4d924adfcbd19d661a18133a0 # v2.35.2
110+
uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # 2.37.2
110111
with:
111112
php-version: ${{ matrix.php-versions }}
112113
# https://docs.nextcloud.com/server/stable/admin_manual/installation/source_installation.html#prerequisites-for-manual-installation
113-
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
114+
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite, redis
114115
coverage: none
115116
ini-file: development
116117
# Temporary workaround for missing pcntl_* in PHP 8.3
@@ -120,17 +121,21 @@ jobs:
120121

121122
- name: Check composer file existence
122123
id: check_composer
123-
uses: andstor/file-existence-action@076e0072799f4942c8bc574a82233e1e4d13e9d6 # v3.0.0
124+
uses: andstor/file-existence-action@558493d6c74bf472d87c84eab196434afc2fa029 # v3.1.0
124125
with:
125126
files: apps/${{ env.APP_NAME }}/composer.json
126127

127-
- name: Set up dependencies
128+
- name: Remove nextcloud/ocp
128129
# Only run if phpunit config file exists
129130
if: steps.check_composer.outputs.files_exists == 'true'
130131
working-directory: apps/${{ env.APP_NAME }}
131132
run: |
132133
composer remove nextcloud/ocp --dev --no-scripts
133-
composer i
134+
135+
- name: Install composer dependencies
136+
uses: ramsey/composer-install@65e4f84970763564f46a70b8a54b90d033b3bdda # 4.0.0
137+
with:
138+
working-directory: apps/${{ env.APP_NAME }}
134139

135140
- name: Set up Nextcloud
136141
env:

‎.github/workflows/pr-feedback.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
blocklist=$(curl https://raw.githubusercontent.com/nextcloud/.github/master/non-community-usernames.txt | paste -s -d, -)
3737
echo "blocklist=$blocklist" >> "$GITHUB_OUTPUT"
3838
39-
- uses: nextcloud/pr-feedback-action@f0cab224dea8e1f282f9451de322f323c78fc7a5 # main
39+
- uses: nextcloud/pr-feedback-action@5227c55be184087d0aef6338bee210d8620b6297 # v1.0.1
4040
with:
4141
feedback-message: |
4242
Hello there,

‎.github/workflows/psalm-matrix.yml‎

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,16 @@ jobs:
2222
runs-on: ubuntu-latest-low
2323
outputs:
2424
ocp-matrix: ${{ steps.versions.outputs.ocp-matrix }}
25+
php-min: ${{ steps.versions.outputs.php-min }}
2526
steps:
2627
- name: Checkout app
27-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
28+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
2829
with:
2930
persist-credentials: false
3031

3132
- name: Get version matrix
3233
id: versions
33-
uses: icewind1991/nextcloud-version-matrix@58becf3b4bb6dc6cef677b15e2fd8e7d48c0908f # v1.3.1
34+
uses: icewind1991/nextcloud-version-matrix@8a7bac6300b2f0f3100088b297995a229558ddba # v1.3.2
3435

3536
- name: Check enforcement of minimum PHP version ${{ steps.versions.outputs.php-min }} in psalm.xml
3637
run: grep 'phpVersion="${{ steps.versions.outputs.php-min }}' psalm.xml
@@ -46,32 +47,33 @@ jobs:
4647
name: static-psalm-analysis ${{ matrix.ocp-version }}
4748
steps:
4849
- name: Checkout
49-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
50+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
5051
with:
5152
persist-credentials: false
5253

53-
- name: Set up php${{ matrix.php-min }}
54-
uses: shivammathur/setup-php@ccf2c627fe61b1b4d924adfcbd19d661a18133a0 # v2.35.2
54+
- name: Set up php${{ needs.matrix.outputs.php-min }}
55+
uses: shivammathur/setup-php@f3e473d116dcccaddc5834248c87452386958240 # 2.37.2
5556
with:
56-
php-version: ${{ matrix.php-min }}
57-
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite, redis
57+
php-version: ${{ needs.matrix.outputs.php-min }}
58+
extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
5859
coverage: none
5960
ini-file: development
6061
# Temporary workaround for missing pcntl_* in PHP 8.3
6162
ini-values: disable_functions=
6263
env:
6364
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6465

65-
- name: Install dependencies
66+
- name: Remove nextcloud/ocp
6667
run: |
6768
composer remove nextcloud/ocp --dev --no-scripts
68-
composer i
6969
70-
- name: Check for vulnerable PHP dependencies
71-
run: composer require --dev roave/security-advisories:dev-latest
70+
- name: Install composer dependencies
71+
uses: ramsey/composer-install@65e4f84970763564f46a70b8a54b90d033b3bdda # 4.0.0
7272

73-
- name: Install dependencies # zizmor: ignore[template-injection]
74-
run: composer require --dev 'nextcloud/ocp:${{ matrix.ocp-version }}' --ignore-platform-reqs --with-dependencies
73+
- name: Install nextcloud/ocp:${{ matrix.ocp-version }}
74+
env:
75+
OCP_VERSION: ${{ matrix.ocp-version }}
76+
run: composer require --dev "nextcloud/ocp:$OCP_VERSION" --ignore-platform-reqs --with-dependencies
7577

7678
- name: Run coding standards check
7779
run: composer run psalm -- --threads=1 --monochrome --no-progress --output-format=github

‎.github/workflows/reuse.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ jobs:
1919
runs-on: ubuntu-latest-low
2020
steps:
2121
- name: Checkout
22-
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
22+
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
2323
with:
2424
persist-credentials: false
2525

2626
- name: REUSE Compliance Check
27-
uses: fsfe/reuse-action@bb774aa972c2a89ff34781233d275075cbddf542 # v5.0.0
27+
uses: fsfe/reuse-action@676e2d560c9a403aa252096d99fcab3e1132b0f5 # v6.0.0

0 commit comments

Comments
 (0)