fix: Replace window.onload with addEventListener for better event handling and hide spinner in skeleton functions

Author: jokob-sk

front/events.php

@@ -261,7 +261,7 @@ function hideEventsSkeleton() {
   $('#events-skeleton').fadeOut(250, function () { $(this).remove(); });
 }
 
-window.onload = function () {
+window.addEventListener('load', function () {
   setTimeout(hideEventsSkeleton, 15000);
-};
+});
 </script>

front/pluginsCore.php

@@ -294,6 +294,8 @@ function genericSaveData (id) {
     generateTabs();
   } catch (err) {
     console.error("Failed to load data", err);
+    hideSpinner();
+    hidePluginsSkeleton();
   }
 }
 
@@ -865,7 +867,7 @@ function hidePluginsSkeleton() {
 }
 
 window.addEventListener('load', function() {
-  setTimeout(hidePluginsSkeleton, 15000);
+  setTimeout(function() { hidePluginsSkeleton(); hideSpinner(); }, 15000);
 });
 
 </script>

front/presence.php

@@ -510,6 +510,7 @@ function getDevicesPresence (status) {
 };
 
 function hidePresenceSkeleton() {
+  hideSpinner();
   $('#presence-skeleton').fadeOut(250, function() { $(this).remove(); });
 }
 

front/userNotifications.php

@@ -221,9 +221,9 @@ function hideNotificationsSkeleton() {
   $('#notifications-skeleton').fadeOut(250, function () { $(this).remove(); });
 }
 
-window.onload = function () {
+window.addEventListener('load', function () {
   setTimeout(hideNotificationsSkeleton, 15000);
-};
+});
 
 </script>
 

front/workflowsCore.php

@@ -1378,6 +1378,7 @@ function saveWorkflows()
 });
 
 function hideWorkflowsSkeleton() {
+  hideSpinner();
   $('#workflows-skeleton').fadeOut(250, function() { $(this).remove(); });
 }