Suggestion to disable buggy auto capitalization

[ernierasta]

Hi!
First - thank you, for great project and your hard work put into it.

I would suggest we would get rid of automatic capitalization of item names. Why?

• It is OK for English to have "My Great Item", but in many languages this looks strange.
• As this is very simplistic implementation - it ignores UTF-8 multibyte chars, so for example "Świetny różowy królik" will be shown as "ŚWietny Różowy Królik" (this will happen with other chars also).
• When no capital (English) letter is found all words are capitalized, so in many languages this creates inconsistency.

I think this correction of names is not needed anymore. I had tested it only checking few random items in Voxelibre, but it would seem it is good in sources. But maybe other games suffer this inconsistency?

Maybe it should be enabled only for English localization?

Of course it could be fixed adding UTF-8 awareness, but it would still often be not what we want.

If anyone want to test disabling this, you can comment it in src/gui.lua lines 63 - 65.
Here is diff:

diff --git a/src/gui.lua b/src/gui.lua
index 761ba08..ff54454 100644
--- a/src/gui.lua
+++ b/src/gui.lua
@@ -59,11 +59,11 @@ local function get_desc(item, lang_code)
 
        if true_str(desc) then
                desc = desc:trim():gsub("_", " ")
-
+               --[[
                if not find(desc, "%u") then
                        desc = toupper(desc)
                end
-
+               ]]
                return desc
 
        elseif true_str(item) then

What do you think about this?

[wsor4035]

would accept a pr for fixing the utf8 issue