fix(client): fix crashes, endless loading and lost links found by e2e tests (#389)

Author: mregni

boardgametracker.client/e2e/auth/redirects.spec.ts

@@ -34,7 +34,7 @@ const protectedPages = [
 	"/games?view=table",
 ];
 
-const losesDeepLink = ["/games/import/start", "/sessions/new", "/sessions/new/1", "/sessions/update/1", "/chat"];
+const switchedOffPages: Record<string, string> = { "/games/import/start": "/games", "/chat": "/" };
 
 for (const path of protectedPages) {
 	test(`sends a visitor from ${path} to the login page`, async ({ guestPage: page }) => {
@@ -43,11 +43,7 @@ for (const path of protectedPages) {
 		await expect(page.getByRole("button", { name: "Sign in" })).toBeVisible();
 		await expect(page).toHaveURL(/\/login\?/);
 		await expect(page.getByRole("complementary")).toHaveCount(0);
-		test.fail(
-			losesDeepLink.includes(path),
-			"BUG: a visitor loses the deep link to this page and lands elsewhere after signing in",
-		);
-		expect(new URL(page.url()).searchParams.get("redirect")).toBe(path);
+		expect(new URL(page.url()).searchParams.get("redirect")).toBe(switchedOffPages[path] ?? path);
 	});
 }
 

boardgametracker.client/e2e/compare/compare.spec.ts

@@ -375,7 +375,6 @@ test("explains when the comparison cannot be loaded", async ({ page }) => {
 
 	await page.goto(compareUrl(busiest, rival));
 
-	test.fail(true, "BUG: /compare keeps spinning forever when the comparison request fails");
 	await expect(page.getByText("Couldn't load this page")).toBeVisible({ timeout: 3000 });
 });
 
@@ -384,6 +383,5 @@ test("explains when the players cannot be loaded", async ({ page }) => {
 
 	await page.goto("/compare");
 
-	test.fail(true, "BUG: /compare says there are not enough players when the player list fails to load");
 	await expect(page.getByText("Couldn't load this page")).toBeVisible({ timeout: 3000 });
 });

boardgametracker.client/e2e/game-nights/detail.spec.ts

@@ -402,11 +402,14 @@ test.describe("a finished night as a reader", () => {
 	});
 });
 
-test("shows an error instead of a crash for an address that is no number", async ({ readerPage: page }) => {
-	await page.goto("/game-nights/abc");
+test.describe("an address that is no number", () => {
+	test.use({ allowedApiStatuses: [401, 404] });
+
+	test("shows an error instead of a crash for an address that is no number", async ({ readerPage: page }) => {
+		await page.goto("/game-nights/abc");
 
-	test.fail(true, "BUG: /game-nights/abc throws in the route params and lands on the generic error page");
-	await expect(page.getByRole("main").getByRole("button", { name: "Game nights" })).toBeVisible({ timeout: 3_000 });
+		await expect(page.getByRole("main").getByRole("button", { name: "Game nights" })).toBeVisible({ timeout: 3_000 });
+	});
 });
 
 test("ignores an unknown start value in the address", async ({ page }) => {
@@ -427,7 +430,6 @@ test.describe("a night that does not exist", () => {
 	test("explains it instead of loading forever", async ({ page }) => {
 		await openMissing(page);
 
-		test.fail(true, "BUG: /game-nights/9999 stays on Loading data... forever, the detail page has no not-found state");
 		await expect(page.getByRole("main").getByText("Loading data...")).toHaveCount(0, { timeout: 5_000 });
 	});
 

boardgametracker.client/e2e/games/sessions.spec.ts

@@ -124,6 +124,16 @@ test("keeps a session when deleting is cancelled", async ({ page }) => {
 	await expect(rowsOf(page)).toHaveCount(played.length);
 });
 
+test.describe("a session that does not exist", () => {
+	test.use({ allowedApiStatuses: [401, 404] });
+
+	test("explains it instead of loading forever", async ({ page }) => {
+		await page.goto("/sessions/update/999999");
+
+		await expect(page.getByRole("main").getByRole("heading", { name: "Couldn't load this page" })).toBeVisible();
+	});
+});
+
 test.describe("a game that does not exist", () => {
 	test.use({ allowedApiStatuses: [401, 404] });
 

boardgametracker.client/e2e/leaderboard/leaderboard.spec.ts

@@ -307,7 +307,6 @@ test("explains when the leaderboard cannot be loaded", async ({ page }) => {
 
 	await page.goto("/leaderboard");
 
-	test.fail(true, "BUG: /leaderboard keeps spinning forever when the leaderboard request fails");
 	await expect(page.getByText("Couldn't load this page")).toBeVisible({ timeout: 3000 });
 });
 

boardgametracker.client/e2e/loans/loans.spec.ts

@@ -383,7 +383,6 @@ test.describe("other data", () => {
 			await page.route("**/api/loans", (route) => route.fulfill({ status: 400, json: {} }));
 			await page.goto("/loans");
 
-			test.fail(true, "BUG: a failed /api/loans request shows the empty page 'No loans yet' instead of an error");
 			await expect(page.getByRole("main").getByRole("button", { name: "Try again" })).toBeVisible({ timeout: 3_000 });
 		});
 	});

boardgametracker.client/e2e/locations/locations.spec.ts

@@ -244,7 +244,6 @@ test.describe("not found", () => {
 		test(`treats the id ${id} as not found`, async ({ page }) => {
 			await page.goto(`/locations/${id}`);
 
-			test.fail(true, "BUG: an invalid location id shows the generic error page instead of 'Location not found'");
 			await expect(page.getByRole("heading", { name: "Location not found", level: 1 })).toBeVisible({
 				timeout: 3_000,
 			});

boardgametracker.client/e2e/phone/dialogs.spec.ts

@@ -292,10 +292,6 @@ test("every action of the last user can be reached", async ({ page }) => {
 		.last()
 		.click();
 
-	test.fail(
-		true,
-		"BUG: the actions menu of the last row opens downward behind the bottom bar and Delete cannot be reached",
-	);
 	await page.getByRole("menuitem").last().click({ trial: true, timeout: 3000 });
 });
 

boardgametracker.client/e2e/phone/layout.spec.ts

@@ -282,10 +282,6 @@ for (const { path, heading, allowed404, content } of pages) {
 
 			await expect(page.getByRole("heading", { name: heading, level: 1, exact: true })).toBeVisible();
 			await expectContentClearsBars(page);
-			test.fixme(
-				path === `/players/${kermit}`,
-				"BUG: in about a third of the loads the Head-to-head and Most played cards make the player page 4px too wide",
-			);
 			await expectNoSidewaysScroll(page);
 		});
 
@@ -385,7 +381,6 @@ test("reloading the edit page of a session opens the form", async ({ page }) =>
 	await page.setViewportSize(phone);
 	await page.goto("/sessions/update/1");
 
-	test.fail(true, "BUG: a reload of the session edit page shows the error page because the loader runs before auth");
 	await expect(page.getByRole("heading", { name: "Something went wrong" })).toHaveCount(0);
 	await expect(page.getByRole("spinbutton", { name: "Duration" })).toBeVisible({ timeout: 3000 });
 });

boardgametracker.client/e2e/phone/manage.spec.ts

@@ -237,10 +237,6 @@ test("a long game title in most played keeps the player page on a phone", async
 		await settled(page);
 		await expect(page.getByRole("heading", { name: "Most played games", level: 2 })).toBeVisible();
 
-		test.fail(
-			true,
-			"BUG: a long title in Most played widens the grid of the player page, so the page scrolls sideways",
-		);
 		await expectNoSidewaysScroll(page);
 	} finally {
 		await api.tidy(`/api/session/${session.id}`);