Upgrade rust toolchain to nightly-2023-06-20#2551
Merged
Merged
Conversation
celinval
added a commit
that referenced
this pull request
Jun 21, 2023
This PR fixes a few flaky tests that started to fail in the ongoing toolchain update (#2551) - The object bits test itself doesn't create that many objects since an array is represented as the same allocated object. Use LinkedList instead. - Do not rely on property number. - Do not rely on the order that failed checks is printed.
c9a43ca to
8b3ed9e
Compare
- Still need to clean regression
- We were crashing while compiling the standard library
Use u8 instead of i8 for now and add a performance test to capture this issue.
8b3ed9e to
8ef1847
Compare
Contributor
Author
|
For the |
adpaco
reviewed
Jul 3, 2023
Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
Contributor
Author
Yeah, sorry about that. The problem already existed, and it just got even worse. Fixing it will take a bit of time. Maybe I'll at least disable the redundant Cbmc checks for now, since that's an easy fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Change Kani's compiler and tests to adapt to changes done to the toolchain. The biggest changes were:
rvalue.rsinstead of intrinsics due to lowering of intrinsics toBinOp.Here is a list of changes that I found that impacted this upgrade:
c"foo"literals rust-lang/rust#108801unchecked_div/_remto MIR'sBinOp::Div/Remrust-lang/rust#112168BinOps rust-lang/rust#112238tcx.mk_trait_refwithTraitRef::newrust-lang/rust#110806EarlyBinder's inner value private rust-lang/rust#112006rustc_const_evalrust-lang/rust#111677-is given as output file rust-lang/rust#111626EarlyBinder::new->EarlyBinder::bindrust-lang/rust#112060tcx.mk_re_*withRegion::new_*rust-lang/rust#112075&format("...")calls in error message code. rust-lang/rust#111633Resolved issues:
Resolves #2544
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
This is still a draft PR. Before publishing it, I still need to:1. I'll pull a bunch of the tests changes to a separate PR before publishing it.2. This is still BLOCKED by a performance degradation on one of our tests.I created #2576 to track a performance issue caused by this upgrade. I modified the regression test to go around the performance issue and created a new test that still captures the issue and is part of the performance CI job instead.Note: I don't think there is anything complicated to actually implement C string literal support, but decided to keep this simple for now. We would also likely want to add more thorough tests too.
Testing:
How is this change tested?
Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.