chore: enable and fix noctx issues

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

Author: mmorel-35

.golangci.yml

@@ -12,6 +12,7 @@ linters:
     - ineffassign
     - misspell
     - modernize
+    - noctx
     - revive
     - unconvert
     - unused

agent/testutils/fakes.go

@@ -233,17 +233,18 @@ func NewMockDispatcher(t *testing.T, secConfig *ca.SecurityConfig, local bool) (
 		addr    string
 		cleanup func()
 	)
+	lc := &net.ListenConfig{}
 	if local {
 		tempDir, err := os.MkdirTemp("", "local-dispatcher-socket")
 		require.NoError(t, err)
 		addr = filepath.Join(tempDir, "socket")
-		l, err = net.Listen("unix", addr)
+		l, err = lc.Listen(t.Context(), "unix", addr)
 		require.NoError(t, err)
 		cleanup = func() {
 			os.RemoveAll(tempDir)
 		}
 	} else {
-		l, err = net.Listen("tcp", "127.0.0.1:0")
+		l, err = lc.Listen(t.Context(), "tcp", "127.0.0.1:0")
 		require.NoError(t, err)
 		addr = l.Addr().String()
 	}

ca/testutils/cautils.go

@@ -154,12 +154,19 @@ func newTestCA(t *testing.T, tempBaseDir string, apiRootCA api.RootCA, krwGenera
 	}
 
 	var (
+		ctx                   context.Context
 		externalSigningServer *ExternalSigningServer
 		externalCAs           []*api.ExternalCA
 		err                   error
 		rootCA                ca.RootCA
 	)
 
+	if t != nil {
+		ctx = t.Context()
+	} else {
+		ctx = context.Background()
+	}
+
 	if apiRootCA.RootRotation != nil {
 		rootCA, err = ca.NewRootCA(
 			apiRootCA.CACert, apiRootCA.RootRotation.CACert, apiRootCA.RootRotation.CAKey, ca.DefaultNodeCertExpiration, apiRootCA.RootRotation.CrossSignedCACert)
@@ -230,7 +237,7 @@ func newTestCA(t *testing.T, tempBaseDir string, apiRootCA api.RootCA, krwGenera
 		assert.NoError(t, err)
 	}
 
-	l, err := net.Listen("tcp", "127.0.0.1:0")
+	l, err := (&net.ListenConfig{}).Listen(ctx, "tcp", "127.0.0.1:0")
 	if t != nil {
 		assert.NoError(t, err)
 	}

ca/transport.go

@@ -87,7 +87,7 @@ func (c *MutableTLSCreds) ClientHandshake(ctx context.Context, addr string, rawC
 	var err error
 	errChannel := make(chan error, 1)
 	go func() {
-		errChannel <- conn.Handshake()
+		errChannel <- conn.HandshakeContext(ctx)
 	}()
 	select {
 	case err = <-errChannel:
@@ -106,7 +106,7 @@ func (c *MutableTLSCreds) ServerHandshake(rawConn net.Conn) (net.Conn, credentia
 	c.Lock()
 	conn := tls.Server(rawConn, c.config)
 	c.Unlock()
-	if err := conn.Handshake(); err != nil {
+	if err := conn.HandshakeContext(context.Background()); err != nil {
 		rawConn.Close()
 		return nil, nil, err
 	}

cmd/swarm-bench/collector.go

@@ -22,7 +22,7 @@ type Collector struct {
 // once they come online.
 func (c *Collector) Listen(port int) error {
 	var err error
-	c.ln, err = net.Listen("tcp", ":"+strconv.Itoa(port))
+	c.ln, err = (&net.ListenConfig{}).Listen(context.Background(), "tcp", ":"+strconv.Itoa(port))
 	return err
 }
 

connectionbroker/broker.go

@@ -4,6 +4,7 @@
 package connectionbroker
 
 import (
+	"context"
 	"net"
 	"sync"
 	"time"
@@ -69,7 +70,7 @@ func (b *Broker) SelectRemote(dialOpts ...grpc.DialOption) (*Conn, error) {
 		grpc.WithUnaryInterceptor(grpc_prometheus.UnaryClientInterceptor),
 		grpc.WithStreamInterceptor(grpc_prometheus.StreamClientInterceptor),
 		grpc.WithDialer(func(addr string, timeout time.Duration) (net.Conn, error) {
-			return net.DialTimeout("tcp", addr, timeout)
+			return (&net.Dialer{Timeout: timeout}).DialContext(context.Background(), "tcp", addr)
 		}))
 
 	cc, err := grpc.Dial(peer.Addr, dialOpts...)

manager/controlapi/ca_rotation.go

@@ -117,7 +117,7 @@ func validateExternalCAURL(dialer *net.Dialer, tlsOpts *tls.Config, caURL string
 		port = "443"
 	}
 
-	conn, err := tls.DialWithDialer(dialer, "tcp", net.JoinHostPort(host, port), tlsOpts)
+	conn, err := (&tls.Dialer{NetDialer: dialer, Config: tlsOpts}).DialContext(context.Background(), "tcp", net.JoinHostPort(host, port))
 	if conn != nil {
 		conn.Close()
 	}

manager/manager.go

@@ -401,7 +401,7 @@ func (m *Manager) BindRemote(ctx context.Context, addrs RemoteAddrs) error {
 		advertiseAddr = net.JoinHostPort("0.0.0.0", advertiseAddrPort)
 	}
 
-	l, err := net.Listen("tcp", addrs.ListenAddr)
+	l, err := (&net.ListenConfig{}).Listen(context.Background(), "tcp", addrs.ListenAddr)
 	if err != nil {
 		return errors.Wrap(err, "failed to listen on remote API address")
 	}

manager/state/raft/testutils/testutils.go

@@ -290,7 +290,7 @@ var _ raft.EncryptionKeyRotator = NewSimpleKeyRotator(raft.EncryptionKeys{})
 
 // NewNode creates a new raft node to use for tests
 func NewNode(t *testing.T, clockSource *fakeclock.FakeClock, tc *cautils.TestCA, opts ...raft.NodeOptions) *TestNode {
-	l, err := net.Listen("tcp", "127.0.0.1:0")
+	l, err := (&net.ListenConfig{}).Listen(t.Context(), "tcp", "127.0.0.1:0")
 	require.NoError(t, err, "can't bind to raft service port")
 	wrappedListener := NewWrappedListener(l)
 

manager/state/raft/transport/transport.go

@@ -351,8 +351,8 @@ func (t *Transport) dial(addr string) (*grpc.ClientConn, error) {
 	// gRPC dialer connects to proxy first. Provide a custom dialer here avoid that.
 	// TODO(anshul) Add an option to configure this.
 	grpcOptions = append(grpcOptions,
-		grpc.WithDialer(func(addr string, timeout time.Duration) (net.Conn, error) {
-			return net.DialTimeout("tcp", addr, timeout)
+		grpc.WithContextDialer(func(ctx context.Context, addr string) (net.Conn, error) {
+			return (&net.Dialer{}).DialContext(ctx, "tcp", addr)
 		}))
 
 	// TODO(dperny): this changes the max received message size for outgoing