Skip to content

Stale generated custom-connection.test.ts for a type removed from the schema (4 TS failures) #451

Description

Summary

runtime/typescript/packages/core/tests/model/connection/custom-connection.test.ts is committed generated output for a CustomConnection type that no longer exists in the schema. It produces 4 vitest failures and survives regeneration untouched.

Failures

FAIL tests/model/connection/custom-connection.test.ts > CustomConnection > construction > should create a new instance with defaults FAIL tests/model/connection/custom-connection.test.ts > CustomConnection > construction > should create a new instance with partial initialization FAIL tests/model/connection/custom-connection.test.ts > CustomConnection > load and save > should load from dictionary FAIL tests/model/connection/custom-connection.test.ts > CustomConnection > load and save > should save to dictionary

all TypeError: CustomConnection is not a constructor.

Evidence it is stale

  • CustomConnection appears nowhere in schema/.
  • It appears nowhere in generated runtime/typescript/packages/core/src/.
  • A full npm run generate (Compilation completed successfully.) does not modify or remove the test file.
  • Its dictionary test still uses the pre-0.4.19 = {} shape, which dates it to before that release.

It was introduced by commit 92e23806.

Why it needs a manual delete

The emitter does not prune generated files whose source type has been removed — it writes the current type set and leaves everything else. I have filed that gap upstream as sethjuarez/typra#69, but even once it is addressed, this particular file is already committed here and needs deleting.

Suggested fix

git rm runtime/typescript/packages/core/tests/model/connection/custom-connection.test.ts

Worth flagging

These 4 failures sit in the same directory as connection-roundtrip-vectors.test.ts and surfaced alongside a genuine open-discriminator defect, so they read plausibly as the same root cause. They are not — that defect is fixed in @typra/emitter@0.4.21, and these 4 are unrelated.

Not verified

I checked only the TypeScript output directory. Other backends may carry similar orphans; I did not audit them.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions