Skip to content

Change all log_write by metacall_throw_error #720

@viferga

Description

@viferga

We should start to use this type of error in the cases that values are involved.

		if (i < (int64_t)LONG_MIN || i > (int64_t)LONG_MAX)
		{
			log_write("metacall", LOG_LEVEL_ERROR, "64-bit signed integer value overflows long in RapidJSON implementation");
			return (value)metacall_error_throw("RapidJSON", -1, NULL, "64-bit signed integer value overflows long in RapidJSON implementation");
		}

But I have also noticed that the log pattern is getting repeated. Another step towards this would be to put the log_write inside the metacall_error_throw only for when compiling in debug.

#667 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions