Add github action for trusted publishing to crates.io#177
Conversation
ginnyTheCat
left a comment
There was a problem hiding this comment.
Looks good. It sadly doesn't unblock #165 yet though, like you stated in the linked issue, since #149 (comment) is still unresolved :/
|
Well, I really really would love to have some of the 0.6.0 changes so I would love to help out on #149 too if I can. Is there anything I can do to help out on that front? I'm not that knowledgeable on FFI but I am happy to help out if possible. Otherwise I guess I'll just update my project to use |
It would be a simple change, the main issue is a decision about the following options to be made:
since this only affects windows (where people are likely using rustup or choco) and 1.89.0 is only the second newest version now i think the second option would be fine, i would just like to have a second opinion on this.
I'm currently doing that as well and it's not great. Makes me question life ever time it clones curl again hahahahhaha |
|
I see! For what its worth, I think the second options sounds like a good idea.
|
I think this is fine, not a big deal. Feel free to release 0.6.0 when you think it's ready. |
This github action should match the configuration outlined in #165 by @messense
I've tested it on my own at https://github.com/vincent-uden/dummy-trusted which uses mupdf as a dependency to check that the compilation does indeed work.
The action would publish to crates.io on each tag starting with "v", as in "v0.6.0" which adheres to the current naming scheme of versions for release.