IOS-12694: Video player: playback controls remain visible while scrubbing the timeline

(cherry picked from commit 217cedf)

217cedf IOS-12694: Video player: playback controls remain visible while scrubbing the timeline

Co-authored-by: Jeff Fang <yfa@mega.co.nz>

Author: mega-yfa

Modules/Features/MEGAVideoPlayer/Sources/MEGAVideoPlayer/Overlay/PlayerOverlayView.swift

@@ -90,8 +90,10 @@ public struct PlayerOverlayView: View {
                     }
 
                     if viewModel.isControlsVisible {
-                        topToolbar
-                        centerPlaybackButtons
+                        if !viewModel.isScrubbing {
+                            topToolbar
+                            centerPlaybackButtons
+                        }
                         bottomToolbar(isLandscape: isLandscape)
                     }
 
@@ -142,7 +144,7 @@ public struct PlayerOverlayView: View {
     }
 
     private var backgroundColor: Color {
-        if viewModel.isControlsVisible {
+        if viewModel.isControlsVisible && !viewModel.isScrubbing {
             TokenColors.Background.blur.swiftUI
         } else {
             Color.clear

Modules/Features/MEGAVideoPlayer/Sources/MEGAVideoPlayer/Overlay/PlayerOverlayViewModel.swift

@@ -32,11 +32,11 @@ public final class PlayerOverlayViewModel: ObservableObject {
     @Published var isExternalPlaybackActive: Bool = false
     @Published var audioTrackSelection: AudioTrackSelection?
     @Published var isAudioTrackMenuPresented: Bool = false
+    /// Whether a finger is currently on the seek bar
+    @Published private(set) var isScrubbing = false
     private(set) var shouldShowPhotoPermissionAlert = false
     private var shouldShowAudioTrackMenu = false
     private var isHoldToSpeed = false
-    /// Whether a finger is currently on the seek bar
-    private(set) var isScrubbing = false
     private var shouldResumeAfterScrub = false
     private var autoHideTimer: Timer?
     private var doubleTapSeekTimer: Timer?

Modules/Features/MEGAVideoPlayer/Tests/MEGAVideoPlayerTests/PlayerOverlayViewModelTests.swift

@@ -894,6 +894,28 @@ struct PlayerOverlayViewModelTests {
         #expect(mockPlayer.pauseCallCount == expectedPauseCallCount)
     }
 
+    /// While scrubbing, the overlay hides the top toolbar, the playback buttons and the dimming layer
+    /// based on `isScrubbing`, so the drag must publish its start and end. `isControlsVisible` is left
+    /// untouched, so the controls reappear on their own once the finger lifts.
+    @Test
+    func seekBarDrag_shouldPublishScrubbingWithoutHidingControls() async {
+        let sut = makeSUT()
+        sut.duration = .seconds(100)
+        sut.state = .playing
+        let frame = CGRect(x: 0, y: 0, width: 100, height: 20)
+        var publishedValues: [Bool] = []
+        let cancellable = sut.$isScrubbing.sink { publishedValues.append($0) }
+
+        await sut.updateSeekBarDrag(at: CGPoint(x: 10, y: 10), in: frame)
+        #expect(sut.isControlsVisible == true)
+
+        await sut.endSeekBarDrag(at: CGPoint(x: 20, y: 10), in: frame)
+
+        #expect(publishedValues == [false, true, false])
+        #expect(sut.isControlsVisible == true)
+        cancellable.cancel()
+    }
+
     @Test(arguments: [
         (PlaybackState.playing, 1),
         (.paused, 0)