Repository navigation
Commit 6baffd1
committed
test(webui): measure the shared dialog after its entrance has settled
The shared presentation layer replaced the message dialog with the shared
dialog, and the shared dialog enters over 200ms: the entrance translates and
scales it, so a geometry measured while the entrance runs is not the
dialog's geometry.
- The rewind dialog's surface and action row are the shared dialog's classes
now; the message dialog's own classes are gone
- The two geometry measurements wait for the entrance to finish, the way the
plugin catalogue's own dialog measurement already does
- The session leading marker's column is 24px wide because the disclosure
inside it is a 24px target; the stylesheet says so where the rule is
written, and the assertion still said 18px1 parent 17a6a02 commit 6baffd1
3 files changed
Lines changed: 19 additions & 4 deletions
File tree
- packages/webui/test
- integration
- unit
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
577 | 577 | | |
578 | 578 | | |
579 | 579 | | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
580 | 584 | | |
581 | 585 | | |
582 | 586 | | |
583 | 587 | | |
584 | | - | |
585 | | - | |
| 588 | + | |
| 589 | + | |
586 | 590 | | |
587 | 591 | | |
588 | 592 | | |
| |||
1193 | 1197 | | |
1194 | 1198 | | |
1195 | 1199 | | |
| 1200 | + | |
| 1201 | + | |
| 1202 | + | |
| 1203 | + | |
1196 | 1204 | | |
1197 | 1205 | | |
1198 | 1206 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
343 | 343 | | |
344 | 344 | | |
345 | 345 | | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
346 | 350 | | |
347 | 351 | | |
348 | 352 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
948 | 948 | | |
949 | 949 | | |
950 | 950 | | |
951 | | - | |
952 | | - | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
| 954 | + | |
| 955 | + | |
953 | 956 | | |
954 | 957 | | |
955 | 958 | | |
| |||
0 commit comments