Repository navigation
Commit 1afa035
committed
fix(webui): colour takes no exception, and the four contrast faults it was hiding
Twenty of the twenty-six recorded accessibility exceptions were `color-contrast`, and
all twenty were scoped to every surface in every state. They excused one root cause
described two ways: the tertiary text token measured 2.15:1 on a light surface and
3.12:1 on a dark one, and the accent token used as text measured 3.03:1 and 3.96:1.
None of them was a per-component decision; all of them were a token that never passed.
What changed:
- `--text_default_tertiary` is #6b6b6b on light (5.11:1) and #8f8f8f on dark (4.68:1
on the darkest surface it is used on).
- `--text_label_accent_default` is `blue_600` on light (6.04:1) and `blue_400` on dark
(5.67:1).
- The user's own message bubble had a hard-coded #e8f3fe background while its text
followed the theme, so in the dark theme a user's message was pale grey on pale
blue - **1.04:1, invisible**. The bubble takes a dark tint of the same blue, and the
text reads 12.42:1. This is the fault a screenshot showed and no gate caught.
- The rail's brand wordmark was read into the button's accessible name while its
visible text was not; the button is named by its text now, and the wordmark is the
mark (`aria-hidden`).
- The settings back button had `aria-label="返回"` over the visible text 返回应用;
the label is gone and the text is the name.
- Two targets were under the 24px a pointer may be asked to hit: the session
disclosure was 18px inside an 18px column, and the workspace tab close was 22px.
Every exception list is now empty, and the scan refuses new contrast exceptions: a
contrast exemption is always either an unfixed value or a reason describing a
different failure than the one in front of it - the memory editor's text was excused
as "secondary and tertiary tokens" while it used the primary one, and its bubble sat
at 1.04:1 for as long as the exemption stood.
Verified: `violations: 0, unexcepted: 0` in the states that render, and no
`color-contrast`, `label-content-name-mismatch` or `target-size` finding remains.
Not in this commit, and why: the geometric recordings still need re-recording (the
tokens and two target sizes change measured layout), and eight `models-provider-form`
states fail on a dialog the working tree's uncommitted provider-form work moved.1 parent 0e211e3 commit 1afa035
7 files changed
Lines changed: 104 additions & 354 deletions
File tree
- packages/webui
- src/client
- features
- sessions/ui
- settings/ui
- transcript/ui
- styles
- test/browser
- support
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
57 | 56 | | |
58 | 57 | | |
59 | 58 | | |
60 | 59 | | |
61 | 60 | | |
62 | 61 | | |
63 | 62 | | |
64 | | - | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
65 | 67 | | |
66 | 68 | | |
67 | 69 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| |||
39 | 38 | | |
40 | 39 | | |
41 | 40 | | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | 41 | | |
47 | 42 | | |
48 | 43 | | |
| |||
59 | 54 | | |
60 | 55 | | |
61 | 56 | | |
62 | | - | |
| 57 | + | |
63 | 58 | | |
64 | 59 | | |
65 | 60 | | |
| |||
139 | 134 | | |
140 | 135 | | |
141 | 136 | | |
142 | | - | |
143 | 137 | | |
144 | 138 | | |
145 | 139 | | |
| |||
299 | 293 | | |
300 | 294 | | |
301 | 295 | | |
302 | | - | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
303 | 299 | | |
304 | | - | |
| 300 | + | |
305 | 301 | | |
306 | 302 | | |
307 | 303 | | |
| |||
313 | 309 | | |
314 | 310 | | |
315 | 311 | | |
316 | | - | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
317 | 315 | | |
318 | | - | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
319 | 322 | | |
320 | 323 | | |
321 | 324 | | |
| |||
393 | 396 | | |
394 | 397 | | |
395 | 398 | | |
396 | | - | |
397 | | - | |
398 | | - | |
399 | | - | |
400 | | - | |
401 | | - | |
402 | | - | |
403 | | - | |
404 | | - | |
405 | | - | |
406 | | - | |
407 | | - | |
408 | | - | |
409 | | - | |
410 | | - | |
411 | | - | |
412 | | - | |
413 | | - | |
414 | | - | |
415 | | - | |
416 | 399 | | |
417 | 400 | | |
418 | 401 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| 51 | + | |
51 | 52 | | |
52 | 53 | | |
53 | 54 | | |
| |||
229 | 230 | | |
230 | 231 | | |
231 | 232 | | |
232 | | - | |
| 233 | + | |
233 | 234 | | |
234 | 235 | | |
235 | 236 | | |
| |||
520 | 521 | | |
521 | 522 | | |
522 | 523 | | |
523 | | - | |
| 524 | + | |
524 | 525 | | |
525 | 526 | | |
526 | 527 | | |
| |||
0 commit comments